From: Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ola: Add patch to fix linking issue
Date: Wed, 5 Aug 2015 09:58:08 +0200 [thread overview]
Message-ID: <55C1C210.4040700@green-communications.fr> (raw)
In-Reply-To: <1438748380-5528-1-git-send-email-simon.marchi@polymtl.ca>
On 05/08/2015 06:19, Simon Marchi wrote:
> This patch fixes this autobuild failure:
>
> http://autobuild.buildroot.net/results/e14/e14e1700d4fe359c56be57587bdb509e002e5753/build-end.log
>
> I am not 100% sure of what happens (I am not a C++ expert at all), but
> here it is anyway. I assume that when the definition of
> TCPSocket::ReadDescriptor is embedded in the class definition, no actual
> implementation is generated (all usages of it are inline).
No, the actual implementation is still generated. However, the build
system pass the -fvisibility-inlines-hidden option, so it is not
exported ...
This bug should be present in the whole library, i'm surprised that
only break in this case.
next prev parent reply other threads:[~2015-08-05 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 4:19 [Buildroot] [PATCH] ola: Add patch to fix linking issue Simon Marchi
2015-08-05 7:58 ` Nicolas Cavallari [this message]
2015-08-05 14:54 ` Simon Marchi
2015-08-08 10:44 ` Thomas Petazzoni
2015-08-10 3:11 ` Simon Marchi
2015-08-10 12:44 ` Thomas Petazzoni
2015-08-10 17:45 ` Simon Marchi
2015-08-10 19:09 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C1C210.4040700@green-communications.fr \
--to=nicolas.cavallari@green-communications.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox