Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4 v2] packages: ensure linux supports modules even when not using kernel-module
Date: Mon, 24 Aug 2015 22:42:01 +0200	[thread overview]
Message-ID: <55DB8199.2080903@mind.be> (raw)
In-Reply-To: <445a9cea52e08b8f3d20c717e11e8b397f2f40ff.1440434894.git.yann.morin.1998@free.fr>

On 08/24/2015 06:50 PM, Yann E. MORIN wrote:
> Some packages build kernel modules without using the kernel-module infra
> (because they use custom build systems); they do not automatically get
> the kernel to support modules which is ensured when using the infra.
> 
> It must be done manually for all those packages, whenever they ar
> eenabled.

 are enabled

> 
> Note: the nvidia-driver case does not need the ifeq-block other packages
> use, because it is already enclosed in a more stringent ifeq-block.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: No? Rubinstein <nrubinstein@aldebaran.com>
> Cc: Jan Viktorin <viktorin@rehivetech.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Minor nit:

[snip]
> +# We're building a kernel module without using the kernel-module infra,
> +# so we need to tell we want module support in the kernel:

 The colon at the end of the line is not needed (same for all others).

 Regards,
 Arnout


> +ifeq ($(BR2_PACKAGE_LINUX_FUSION),y)
> +LINUX_NEEDS_MODULES = y
> +endif
> +
>  LINUX_FOR_FUSION = $(LINUX_VERSION_PROBED)
>  LINUX_FUSION_ETC_DIR = $(TARGET_DIR)/etc/udev/rules.d
>  
[snip]


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-08-24 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 16:49 [Buildroot] [PATCH 0/4 v2] core/pkg-kernel-config: ensure linux supports modules (branch yem/kernel-module) Yann E. MORIN
2015-08-24 16:50 ` [Buildroot] [PATCH 1/4 v2] core/pkg-kernel-module: ensure linux supports modules Yann E. MORIN
2015-08-24 20:31   ` Arnout Vandecappelle
2015-08-24 16:50 ` [Buildroot] [PATCH 2/4 v2] core/pkg-kernel-module: drop now-useles check for CONFIG_MODULES Yann E. MORIN
2015-08-24 20:33   ` Arnout Vandecappelle
2015-08-24 16:50 ` [Buildroot] [PATCH 3/4 v2] packages: ensure linux supports modules even when not using kernel-module Yann E. MORIN
2015-08-24 20:42   ` Arnout Vandecappelle [this message]
2015-08-25 12:20   ` Jan Viktorin
2015-08-24 16:50 ` [Buildroot] [PATCH 4/4 v2] package/linux-fusion: slight simplification Yann E. MORIN
2015-08-24 20:45   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DB8199.2080903@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox