Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit@wsystem.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pacakge/qt5/qt5base: fix build with ccache
Date: Thu, 27 Aug 2015 11:12:47 +0200	[thread overview]
Message-ID: <55DED48F.3030102@wsystem.com> (raw)
In-Reply-To: <20150827105450.100164af@free-electrons.com>

Hi,

On 27/08/2015 10:54, Thomas Petazzoni wrote:
> On Thu, 27 Aug 2015 10:12:44 +0200, Beno?t Th?baudeau wrote:
> 
>>> As explained in this report, I think that your suggestion would work
>>> for Buildroot (not yet tested), but not for upstream Qt.
>>>
>>> My point with this patch was that upstream could consider this
>>> Buildroot use case as illegal because the definition of QMAKE_CXX
>>> (http://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-cxx) only
>>> mentions a filename and a path as possibilities. In that case, the bug
>>> is in Buildroot, and since this sanity check of the compiler is not
>>> needed for Buildroot, we can just remove this test. If we don't want a
>>> local patch for this, maybe we could use a wrapper above ccache, or
>>> put ccache into QMAKE_CXX and the compiler into QMAKE_CXXFLAGS (not
>>> tested, and a bit ugly).
>>>
>>> Wait and see what upstream says.
>>
>> Upstream recommends this approach:
>> http://lists.qt-project.org/pipermail/qt-creator/2014-January/003148.html
>>
>> What do you think?
> 
> Well, we already have a wrapper for the compiler in the case of the
> external toolchain. And we will probably also extend the wrapper in the
> future to the internal toolchain case, in order to support per-package
> staging directory. In this case, we could take advantage of this
> wrapper to include the ccache functionality, and avoid having CC and
> CXX values that have two words.
> 
> I really would like to have the wrapper suggested in this e-mail
> calling our wrapper, then calling the real compiler.

OK, but in the meantime, until we have a wrapper for the internal toolchain too,
what do you want to do to fix the current build failure?
 - Forbid the use of ccache with Qt 5?
 - Use the current patch?
 - Use the wrapper from the URL above? In that case, where would you put it in
   Buildroot (qt5base, new package, toolchain, support)?

Best regards,
Beno?t

  reply	other threads:[~2015-08-27  9:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 10:41 [Buildroot] [PATCH] pacakge/qt5/qt5base: fix build with ccache Benoît Thébaudeau
2015-08-26 13:45 ` Thomas Petazzoni
2015-08-26 22:10   ` Benoît Thébaudeau
2015-08-27  8:12     ` Benoît Thébaudeau
2015-08-27  8:54       ` Thomas Petazzoni
2015-08-27  9:12         ` Benoît Thébaudeau [this message]
2015-08-27 12:39           ` Thomas Petazzoni
2015-08-28  9:50             ` Benoît Thébaudeau
2015-08-27 12:49           ` Jaap Crezee
2015-08-27 19:03             ` Benoît Thébaudeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DED48F.3030102@wsystem.com \
    --to=benoit@wsystem.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox