From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Beno=c3=aet_Th=c3=a9baudeau?= <benoit@wsystem.com>
Date: Fri, 28 Aug 2015 12:02:31 +0200
Subject: [Buildroot] [PATCH v2] pacakge/qt5/qt5base: fix build with
	ccache
In-Reply-To: <20150828115749.6e4b4481@free-electrons.com>
References: <1440755211-46875-1-git-send-email-benoit@wsystem.com>
 <20150828115749.6e4b4481@free-electrons.com>
Message-ID: <55E031B7.20308@wsystem.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 28/08/2015 11:57, Thomas Petazzoni wrote:
> On Fri, 28 Aug 2015 11:46:51 +0200, Beno?t Th?baudeau wrote:
> 
>> +diff --git a/mkspecs/features/device_config.prf b/mkspecs/features/device_config.prf
>> +index cd3a0cf..eee4ac6 100644
>> +--- a/mkspecs/features/device_config.prf
>> ++++ b/mkspecs/features/device_config.prf
>> +@@ -19,10 +19,15 @@ defineTest(deviceSanityCheckCompiler) {
>> +     else: \
>> +         sfx =
>> + 
>> ++    # Build the compiler filename using the first value in QMAKE_CXX in order to
>> ++    # support tools like ccache, which give QMAKE_CXX values of the form:
>> ++    #     ccache <path_to_compiler>
>> ++    compiler = $$first(QMAKE_CXX)$$sfx
> 
> Then wouldn't it make more sense to use the last() function, to use the
> last value rather than the first, and actual check the compiler rather
> than ccache?
> 
> 	compiler = $$last(QMAKE_CXX)$$sfx

The last() function could be less portable because there might be some other use
cases out there that we're not thinking about. On the contrary, we're certain
that the first value has to be an executable.

Best regards,
Beno?t