From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/2] udisks: bump to version 1.0.5
Date: Wed, 2 Sep 2015 11:14:59 +0100 [thread overview]
Message-ID: <55E6CC23.2090502@imgtec.com> (raw)
In-Reply-To: <20150902101033.GY17874@tarshish>
Dear Baruch Siach,
On 09/02/2015 11:10 AM, Baruch Siach wrote:
> Hi Vincent,
>
> On Wed, Sep 02, 2015 at 11:05:48AM +0100, Vicente Olivert Riera wrote:
>> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>> +UDISKS_CONF_OPTS += libgudev
>> +endif
>
> So libgudev is not even an optional dependency when there is no systemd?
Well, it wasn't there before, so... Anyway, the default is not to add
every optional dependency in the .mk, and let the users who really need
them to send a patch to do it.
> In any case, a comment explaining this unusual dependency would be nice.
Well, I have copied the output of the error you will face if you don't
depend on libgudev when using systemd. Do you think it's also necessary
in the Config.in and udisks.mk file as well? I don't mind doing it if
you think it is.
Regards,
Vincent.
>
> baruch
>
next prev parent reply other threads:[~2015-09-02 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 10:05 [Buildroot] [PATCHv2 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
2015-09-02 10:05 ` [Buildroot] [PATCHv2 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
2015-09-02 10:10 ` [Buildroot] [PATCHv2 1/2] udisks: bump to version 1.0.5 Baruch Siach
2015-09-02 10:14 ` Thomas Petazzoni
2015-09-02 10:21 ` Baruch Siach
2015-09-02 10:25 ` Vicente Olivert Riera
2015-09-02 10:14 ` Vicente Olivert Riera [this message]
2015-09-02 10:27 ` Baruch Siach
2015-09-02 10:29 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6CC23.2090502@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox