Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-generic: fix <pkg>-legal-info target
Date: Thu, 3 Sep 2015 16:12:38 +0200	[thread overview]
Message-ID: <55E85556.4030103@lucaceresoli.net> (raw)
In-Reply-To: <217433bd5ec057444b036dd8b72778f078f0926e.1441213919.git.baruch@tkos.co.il>

Dear Baruch,

Baruch Siach wrote:
> When making the <pkg>-legal-info target before the main legal-info target, the
> following error shows:
>
> /bin/sh: /home/baruch/git/buildroot/output/legal-info/licenses.txt: No such file or directory
> package/freescale-imx/imx-vpu/imx-vpu.mk:39: recipe for target 'imx-vpu-legal-info' failed
> make: *** [imx-vpu-legal-info] Error 1
>
> Make <pkg>-legal-info depend on legal-info-prepare to ensure that
> $(LEGAL_INFO_DIR) exists when generating licenses.txt.
>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   package/pkg-generic.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 6a7d97efdf02..24b473b13ff2 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -715,7 +715,7 @@ endif
>   endif
>
>   # legal-info: produce legally relevant info.
> -$(1)-legal-info:
> +$(1)-legal-info: legal-info-prepare

Very weird, I can reproduce the bug, but only for packages under
package/freescale/, like imx-vpu. I tested a dozen other packages, and
they all work fine. My test command is:

   git clean -xdf && make defconfig && \
     make BR2_DL_DIR=~/src ${PKG}-legal-info

Any idea of why these packages are special?

-- 
Luca

  reply	other threads:[~2015-09-03 14:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 17:11 [Buildroot] [PATCH] pkg-generic: fix <pkg>-legal-info target Baruch Siach
2015-09-03 14:12 ` Luca Ceresoli [this message]
2015-09-03 14:30   ` Baruch Siach
2015-09-03 22:19     ` Luca Ceresoli
2015-09-03 23:22       ` Arnout Vandecappelle
2015-09-04  7:18         ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E85556.4030103@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox