Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: use a menuconfig for the getty options
Date: Thu, 3 Sep 2015 15:54:14 +0100	[thread overview]
Message-ID: <55E85F16.1050203@imgtec.com> (raw)
In-Reply-To: <1441149034-27282-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On 09/02/2015 12:10 AM, Yann E. MORIN wrote:
> Making the getty option a menuconfig instead of a simple config
> automatically moves its dependees into a menu without the need to
> manually declare such a menu.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  system/Config.in | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index fad829d..ea45cf3 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
>  	default "dash"    if BR2_SYSTEM_BIN_SH_DASH
>  	default "zsh"     if BR2_SYSTEM_BIN_SH_ZSH
>  
> -config BR2_TARGET_GENERIC_GETTY
> +menuconfig BR2_TARGET_GENERIC_GETTY
>  	bool "Run a getty (login prompt) after boot"
>  	default y
>  
>  if BR2_TARGET_GENERIC_GETTY
> -menu "getty options"
>  config BR2_TARGET_GENERIC_GETTY_PORT
>  	string "TTY port"
>  	default "console"
> @@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
>  	help
>  	  Any other flags you want to pass to getty,
>  	  Refer to getty --help for details.
> -endmenu
>  endif
>  
>  config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
> 

Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Regards,

Vincent.

  parent reply	other threads:[~2015-09-03 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 23:10 [Buildroot] [PATCH] system: use a menuconfig for the getty options Yann E. MORIN
2015-09-02 22:13 ` Arnout Vandecappelle
2015-09-03 14:54 ` Vicente Olivert Riera [this message]
2015-10-03 12:26 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E85F16.1050203@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox