Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [bug] bootwrapper runs before linking initrd
Date: Fri, 4 Sep 2015 21:52:50 +0200	[thread overview]
Message-ID: <55E9F692.8040501@mind.be> (raw)
In-Reply-To: <20150904105409.53804439@free-electrons.com>

[Adding Jeremy Kerr in CC - he's the author of
http://patchwork.ozlabs.org/patch/366549/ ]

On 04-09-15 10:54, Thomas Petazzoni wrote:
> Hollis,
> 
> On Thu, 3 Sep 2015 15:00:49 -0700, Hollis Blanchard wrote:
>> I have a BR config that includes the following:
>> BR2_LINUX_KERNEL=y
>> BR2_TARGET_ROOTFS_INITRAMFS=y
>> BR2_TARGET_BOOT_WRAPPER_AARCH64=y
> 
> Yes, this is not working right now.
[snip]
>> What's the real solution? Thanks!
> 
> See http://lists.busybox.net/pipermail/buildroot/2014-July/101052.html
> for a possible solution. I remember we discussed this patch during the
> Buildroot Summer camp, but I thought we had sent some comments for
> Jeremy to improve the patch. But it seems it wasn't done. Arnout, do
> you remember the conclusion of our discussion?

 I did send it:

http://lists.busybox.net/pipermail/buildroot/2015-July/132686.html

(mailmain/pipermail threading sucks)

 TL;DR:

 It was a long discussion, mainly because it doesn't really solve the problem
(which BTW is mainly in the approach we take for linux-with-initramfs - that's
just a huge hack).

 That said, we basically agree with the approach. So if you're stilling willing
to do it, please post a full series including the change to
boot-wrapper-aarch64, taking into account the comments below. We've marked this
patch as Changes Requested in patchwork.


 _However_, I may have an idea for an alternative approach that confines the
hack to boot-wrapper-aarch64 itself. The following may work:

boot-wrapper-aarch64-rebuild-with-initramfs: linux-rebuild-with-initramfs
	$(TARGET_MAKE_ENV) $(MAKE) -C $(BOOT_WRAPPER_AARCH64_SRCDIR)
	cp $(BOOT_WRAPPER_AARCH64_SRCDIR)/linux-system.axf $(BINARIES_DIR)

ROOTFS_INITRAMFS_POST_TARGETS += boot-wrapper-aarch64-rebuild-with-initramfs


I.e., rerun the build and install commands as part of the rootfs-initramfs build
step. Note that no conditions are needed, since this target will anyway only
come into play when rootfs-initramfs is built.

 Can someone give that a try and post a patch?

 Regards,
 Arnout

> 
> I must say I'm not thrilled by making such major changes to Buildroot
> just for the sake of this very specific use-case. But we probably don't
> have much choice.
> 
> Thomas
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

      parent reply	other threads:[~2015-09-04 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 22:00 [Buildroot] [bug] bootwrapper runs before linking initrd Hollis Blanchard
2015-09-04  8:54 ` Thomas Petazzoni
2015-09-04  9:51   ` Peter Korsgaard
2015-09-04 10:39     ` Thomas Petazzoni
2015-09-04 19:52   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E9F692.8040501@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox