Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5
Date: Mon, 7 Sep 2015 09:01:35 +0100	[thread overview]
Message-ID: <55ED445F.7040905@imgtec.com> (raw)
In-Reply-To: <87y4gklrzq.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On 09/05/2015 06:02 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> 
>  > This version depends on libgudev when using systemd, otherwise it fails
>  > with an error like this one:
> 
>  > checking for GUDEV... no
>  > configure: error: Package requirements (gudev-1.0 >= 147) were not met:
> 
>  > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>  > ---
>  > Changes v3 -> v4: improve the libgudev dependency comment [Thomas]
>  > Changes v2 -> v3: add a comment about the libgudev dependency
>  > Changes v1 -> v2: depend on libgudev when using systemd
> 
>  > +++ b/package/udisks/udisks.mk
>  > @@ -4,7 +4,7 @@
>  >  #
>  >  ################################################################################
>  
>  > -UDISKS_VERSION = 1.0.4
>  > +UDISKS_VERSION = 1.0.5
>  >  UDISKS_SITE = http://hal.freedesktop.org/releases
>  >  UDISKS_LICENSE = GPLv2+
>  >  UDISKS_LICENSE_FILES = COPYING
>  > @@ -22,6 +22,15 @@ UDISKS_DEPENDENCIES = 	\
>  
>  >  UDISKS_CONF_OPTS = --disable-remote-access --disable-man-pages
>  
>  > +# When eudev is used as the udev provider, libgudev is automatically
>  > +# provided as it is part of eudev. However, when systemd is used as the
>  > +# udev provider, libgudev is not provided, and needs to be built
>  > +# separately. This is why we select the libgudev package only if systemd
>  > +# is used.
>  > +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>  > +UDISKS_CONF_OPTS += libgudev
> 
> Ehh, don't you mean UDISKS_DEPENDENCIES here?
> 

Ooops!, yes, UDISKS_DEPENDENCIES of course.

Should I send another version or can you amend that?

Thanks,

Vincent.

  reply	other threads:[~2015-09-07  8:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 14:21 [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
2015-09-02 14:21 ` [Buildroot] [PATCHv4 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
2015-09-07 21:46   ` Peter Korsgaard
2015-09-02 21:12 ` [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5 Arnout Vandecappelle
2015-09-03 16:02   ` Thomas Petazzoni
2015-09-03 16:47     ` Arnout Vandecappelle
2015-09-05 17:02 ` Peter Korsgaard
2015-09-07  8:01   ` Vicente Olivert Riera [this message]
2015-09-07  8:19     ` Peter Korsgaard
2015-09-07 21:46 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ED445F.7040905@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox