Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] gdb: prevent building the documentation
Date: Wed, 9 Sep 2015 13:22:14 +0200	[thread overview]
Message-ID: <55F01666.2000402@openwide.fr> (raw)
In-Reply-To: <1441796566-12110-1-git-send-email-Vincent.Riera@imgtec.com>

Hi Vicente,

Le 09/09/2015 13:02, Vicente Olivert Riera a ?crit :
> Force gdb to not build the documentation. This way we avoid depending on
> host-texinfo. This is a temporary fix until upstream accepts a proposed
> --disable-docs configure option.
> 
> Since the documentation will not be build at all, we can remove the
> parts related to host-texinfo and MAKEINFO in the gdb.mk file.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Ok, I'll mark my patches as superseded.

> ---
> Changes v1 -> v2:
>   - Indent the sed command
>   - Use a post-patch-hook instead of pre-configure-hook
>   - Remove the parts related to host-texinfo and MAKEINFO
>   - Ammend the commit log to be more appropriate
> 
>  package/gdb/gdb.mk |   15 ++++++---------
>  1 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 338de20..01b35b0 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -53,6 +53,12 @@ GDB_PRE_PATCH_HOOKS += GDB_XTENSA_PRE_PATCH
>  HOST_GDB_PRE_PATCH_HOOKS += GDB_XTENSA_PRE_PATCH
>  endif
>  
> +# Prevent gdb to build the documentation
> +define GDB_DISABLE_DOC
> +	$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in
> +endef
> +GDB_POST_PATCH_HOOKS += GDB_DISABLE_DOC
> +
>  # When gdb sources are fetched from the binutils-gdb repository, they
>  # also contain the binutils sources, but binutils shouldn't be built,
>  # so we disable it.
> @@ -165,15 +171,6 @@ else
>  HOST_GDB_CONF_OPTS += --without-python
>  endif
>  
> -ifeq ($(GDB_FROM_GIT),y)

Since you remove GDB_FROM_GIT test here, you can also remove "GDB_FROM_GIT = y"
for arc and microblaze.

> -GDB_DEPENDENCIES += host-texinfo
> -HOST_GDB_DEPENDENCIES += host-texinfo
> -else
> -# don't generate documentation
> -GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing
> -HOST_GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing
> -endif
> -
>  # legacy $arch-linux-gdb symlink
>  define HOST_GDB_ADD_SYMLINK
>  	cd $(HOST_DIR)/usr/bin && \
> 

      parent reply	other threads:[~2015-09-09 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 11:02 [Buildroot] [PATCHv2] gdb: prevent building the documentation Vicente Olivert Riera
2015-09-09 11:16 ` Brendan Heading
2015-09-09 11:22 ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F01666.2000402@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox