Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-input-vmmouse: dep on udev
Date: Thu, 10 Sep 2015 17:11:43 +0100	[thread overview]
Message-ID: <55F1ABBF.4070809@imgtec.com> (raw)
In-Reply-To: <1441888256-15742-1-git-send-email-brendanheading@gmail.com>

Dear Brendan Heading,

On 09/10/2015 01:30 PM, Brendan Heading wrote:
> Fixes:
> http://autobuild.buildroot.net/results/cd3/cd3730ed0272c3f335ee90e0cbc4027b07945db3/
> 
> The xdriver_xf86-input-vmmouse driver depends on udev.
> 
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Regards,

Vincent.

> ---
> The driver requires udev, or an option to allow it to build without udev.
> I followed the precedent set by libinput and evdev by adding the
> dependency.
> ---
>  package/x11r7/xdriver_xf86-input-vmmouse/Config.in                    | 4 ++++
>  .../x11r7/xdriver_xf86-input-vmmouse/xdriver_xf86-input-vmmouse.mk    | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> index de989eb..73e1a29 100644
> --- a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> +++ b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> @@ -1,8 +1,12 @@
>  config BR2_PACKAGE_XDRIVER_XF86_INPUT_VMMOUSE
>  	bool "xf86-input-vmmouse"
>  	depends on BR2_i386 || BR2_x86_64
> +	depends on BR2_PACKAGE_HAS_UDEV # libudev is configure dependency
>  	select BR2_PACKAGE_XPROTO_INPUTPROTO
>  	select BR2_PACKAGE_XPROTO_RANDRPROTO
>  	select BR2_PACKAGE_XPROTO_XPROTO
>  	help
>  	  VMWare mouse input driver
> +
> +comment "xf86-input-vmmouse requires udev to be enabled"
> +	depends on !BR2_PACKAGE_HAS_UDEV
> diff --git a/package/x11r7/xdriver_xf86-input-vmmouse/xdriver_xf86-input-vmmouse.mk b/package/x11r7/xdriver_xf86-input-vmmouse/xdriver_xf86-input-vmmouse.mk
> index 53ceec8..3b49c2d 100644
> --- a/package/x11r7/xdriver_xf86-input-vmmouse/xdriver_xf86-input-vmmouse.mk
> +++ b/package/x11r7/xdriver_xf86-input-vmmouse/xdriver_xf86-input-vmmouse.mk
> @@ -9,6 +9,6 @@ XDRIVER_XF86_INPUT_VMMOUSE_SOURCE = xf86-input-vmmouse-$(XDRIVER_XF86_INPUT_VMMO
>  XDRIVER_XF86_INPUT_VMMOUSE_SITE = http://xorg.freedesktop.org/releases/individual/driver
>  XDRIVER_XF86_INPUT_VMMOUSE_LICENSE = MIT
>  XDRIVER_XF86_INPUT_VMMOUSE_LICENSE_FILES = COPYING
> -XDRIVER_XF86_INPUT_VMMOUSE_DEPENDENCIES = xserver_xorg-server xproto_inputproto xproto_randrproto xproto_xproto
> +XDRIVER_XF86_INPUT_VMMOUSE_DEPENDENCIES = xserver_xorg-server xproto_inputproto xproto_randrproto xproto_xproto udev
>  
>  $(eval $(autotools-package))
> 

  reply	other threads:[~2015-09-10 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 12:30 [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-input-vmmouse: dep on udev Brendan Heading
2015-09-10 16:11 ` Vicente Olivert Riera [this message]
2015-09-27 19:15 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F1ABBF.4070809@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox