From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
Date: Sat, 19 Sep 2015 15:51:50 +0200 [thread overview]
Message-ID: <55FD6876.70803@mind.be> (raw)
In-Reply-To: <38121FAB319C3344930C920E7B518313252D32D7@LEMAIL01.le.imgtec.org>
On 19-09-15 10:34, Vincent Olivert Riera wrote:
[snip]
> On 19/09/15 02:55, Hiroshi Kawashima wrote:
[snip]
>> +comment "squeezelite needs a toolchain w/ wchar (incur from flac)"
>
> I would place this comment at the end of the BR2_PACKAGE_SQUEEZELITE,
> before defining the BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE and
> BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP.
No, wrong. The comment should always be either at the beginning or at the end
of the file. Otherwise, the indentation of the sub-options will be wrong (i.e.,
they won't be indented).
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
prev parent reply other threads:[~2015-09-19 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 1:55 [Buildroot] [PATCH 1/1] Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp> Hiroshi Kawashima
2015-09-19 8:34 ` Vincent Olivert Riera
2015-09-19 10:22 ` 川島 浩
2015-09-19 13:51 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FD6876.70803@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox