Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libmng: new package
Date: Thu, 24 Sep 2015 17:22:38 +0100	[thread overview]
Message-ID: <5604234E.5050008@imgtec.com> (raw)
In-Reply-To: <1443105404-30913-1-git-send-email-gustavo.zacarias@free-electrons.com>

Dear Gustavo Zacarias,

On 09/24/2015 03:36 PM, gustavo.zacarias at free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Build test for MIPS architecture:

$ file output/target/usr/lib/libmng.so.2.0.2
output/target/usr/lib/libmng.so.2.0.2: ELF 64-bit LSB shared object,
MIPS, MIPS64 rel2 version 1 (SYSV), dynamically linked, with unknown
capability 0x756e670000000f41 = 0x104000000070100, stripped

One nit-pick comment below; please scroll down.

[snip]

> diff --git a/package/libmng/Config.in b/package/libmng/Config.in
> new file mode 100644
> index 0000000..a0bd59c
> --- /dev/null
> +++ b/package/libmng/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBMNG
> +	bool "libmng"
> +	select BR2_PACKAGE_JPEG
> +	select BR2_PACKAGE_ZLIB
> +	help
> +	  The reference library for reading, displaying, writing and
> +	  examining Multiple-Image Network Graphics.

"examining" could be in the first line as it wouldn't exceed the 72
characters limit.

Regards,

Vincent.

[snip]

  reply	other threads:[~2015-09-24 16:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 14:36 [Buildroot] [PATCH] libmng: new package gustavo.zacarias at free-electrons.com
2015-09-24 16:22 ` Vicente Olivert Riera [this message]
2015-09-24 21:54 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5604234E.5050008@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox