From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] Remove trailing slash from all package site URLs
Date: Sun, 27 Sep 2015 13:50:51 +0200 [thread overview]
Message-ID: <5607D81B.4000101@lucaceresoli.net> (raw)
In-Reply-To: <1443346764-7433-2-git-send-email-luca@lucaceresoli.net>
Hi,
Luca Ceresoli wrote:
> The recommended form is without the trailing slash. Buildroot will
add a slash
> between FOO_SITE and FOO_SOURCE as appropriate.
>
> This avoids the need for the $$($(2)_SITE:/=) magic in
package/pkg-generic.mk
> to avoid double slashes in download URLs, like
> https://mosh.mit.edu//mosh-1.2.5.tar.gz which works but is dirty.
>
> Note: this work has already been done in b0b9606530dfc6de4030 a few
months ago,
> but no check has been added at that time to avoid new slashes to slip
in, and
> so they did. This time a patch will follow immediately to catch future
> mistakes to be unnoticed.
And of course the last sentence should be written in English: "...to
prevent future mistakes from being unnoticed".
--
Luca
next prev parent reply other threads:[~2015-09-27 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 9:39 [Buildroot] [PATCH v2 0/4] Cleanup trailing slashed from FOO_SITE Luca Ceresoli
2015-09-27 9:39 ` [Buildroot] [PATCH v2 1/4] Remove trailing slash from all package site URLs Luca Ceresoli
2015-09-27 11:50 ` Luca Ceresoli [this message]
2015-09-27 9:39 ` [Buildroot] [PATCH v2 2/4] pkg-generic: prevent _SITE URLs with a trailing slash Luca Ceresoli
2015-09-27 9:39 ` [Buildroot] [PATCH v2 3/4] Download: remove trailing slash cleanup for SITE URLs Luca Ceresoli
2015-09-27 9:39 ` [Buildroot] [PATCH v2 4/4] docs/manual: FOO_SITE must not have a trailing slash Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5607D81B.4000101@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox