Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v14 1/1] squeezelite: new package
Date: Wed, 30 Sep 2015 16:18:12 +0100	[thread overview]
Message-ID: <560BFD34.3020409@imgtec.com> (raw)
In-Reply-To: <201509301434.t8UEYCh2003625@ms-omx01.plus.so-net.ne.jp>

Dear Hiroshi Kawashima,

On 09/30/2015 03:34 PM, kei-k at ca2.so-net.ne.jp wrote:
> Dear all.
> 
> I will appreciate if you point out anything I should improve for
> following patch.
> 
> Thanks,
> Kawashima
> 
>> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
>> ---
>> Changelog
>> v13 -> v14
>> - change to use patch file insted of using sed to generate Makefile.

[snip]

>> v12 -> v13
>> - change SQUEEZELITE_SITE to github (mine), cloned from original
>>   google code site (original site is unstable to fetch).

So you own a clone of that project on github, and the package you want
to add in Buildroot clones from it. Great! Then, why not...

[snip]

>> - to accomplish above, change to generate buildroot suitable Makefile from
>>   original squeezelite's Makefile (using 'override' directive for CFLAGS,
>>   LDFLAGS).

...fix the Makefile upstream (your github repo) instead of adding a
patch in Buildroot?

Regards,

Vincent.

[snip]

  reply	other threads:[~2015-09-30 15:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 11:08 [Buildroot] [PATCH v14 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
2015-09-30 14:34 ` kei-k at ca2.so-net.ne.jp
2015-09-30 15:18   ` Vicente Olivert Riera [this message]
2015-09-30 23:04     ` kei-k at ca2.so-net.ne.jp
2015-10-01 11:39       ` kei-k at ca2.so-net.ne.jp
2015-10-01 13:29         ` Vicente Olivert Riera
2015-10-01 13:45           ` kei-k at ca2.so-net.ne.jp
2015-10-06 11:58             ` kei-k at ca2.so-net.ne.jp
2015-10-12 15:53 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560BFD34.3020409@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox