From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Sat, 3 Oct 2015 22:44:21 +0100 Subject: [Buildroot] [PATCH] package: Replace 'echo -n' by 'printf' In-Reply-To: <1443907797-26050-1-git-send-email-maxime.hadjinlian@gmail.com> References: <1443907797-26050-1-git-send-email-maxime.hadjinlian@gmail.com> Message-ID: <56104C35.2050805@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 03-10-15 22:29, Maxime Hadjinlian wrote: > 'echo -n' is not a POSIX construct (no flag support), we shoud use > 'printf', especially in init script. > > This patch was generated by the following command line: > git grep -l 'echo -n' -- `git ls-files | grep -v 'patch'` | xargs sed -i 's/echo -n/printf/' > > Signed-off-by: Maxime Hadjinlian Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Verified that there are no occurences of 'echo -' left except in patches (and in those patches we actually never add it). Visually verified that all of the replacements look sane. There is one replacement in a comment which is a bit silly, and the replacements in helpers.mk and toolchain-external.mk are not really needed, but it's still progress. > --- > package/acpid/S02acpid | 4 ++-- > package/at/S99at | 4 ++-- > package/audit/S01auditd | 8 ++++---- > package/bind/S81named | 6 +++--- > package/busybox/S01logging | 4 ++-- > package/busybox/S50telnet | 4 ++-- > package/c-icap/S96cicap | 4 ++-- > package/chrony/S49chrony | 4 ++-- > package/connman/S45connman | 4 ++-- > package/dbus/S30dbus | 4 ++-- > package/dcron/S90dcron | 4 ++-- > package/dhcp/S80dhcp-relay | 4 ++-- > package/dhcp/S80dhcp-server | 4 ++-- > package/dnsmasq/S80dnsmasq | 4 ++-- > package/dropbear/S50dropbear | 4 ++-- > package/ejabberd/S50ejabberd | 4 ++-- > package/exim/S86exim | 2 +- > package/gpsd/S50gpsd | 4 ++-- > package/haveged/S21haveged | 4 ++-- > package/initscripts/init.d/S20urandom | 4 ++-- > package/initscripts/init.d/S40network | 2 +- > package/input-event-daemon/S99input-event-daemon | 4 ++-- > package/irqbalance/S13irqbalance | 4 ++-- > package/kodi/S50kodi | 4 ++-- > package/lighttpd/S50lighttpd | 4 ++-- > package/lirc-tools/S25lircd | 4 ++-- > package/minidlna/S60minidlnad | 4 ++-- > package/modem-manager/S44modem-manager | 4 ++-- > package/mongoose/S85mongoose | 4 ++-- > package/mosquitto/S50mosquitto | 4 ++-- > package/mpd/S95mpd | 4 ++-- > package/mysql/S97mysqld | 4 ++-- > package/neard/S53neard | 4 ++-- > package/netplug/S29netplug | 4 ++-- > package/netsnmp/S59snmpd | 22 +++++++++++----------- > package/network-manager/S45network-manager | 4 ++-- > package/nfs-utils/S60nfs | 14 +++++++------- > package/nginx/S50nginx | 2 +- > package/ntp/S49ntp | 4 ++-- > package/ofono/S46ofono | 4 ++-- > package/olsr/S50olsr | 4 ++-- > package/openntpd/S49ntp | 4 ++-- > package/openssh/S50sshd | 4 ++-- > package/openvmtools/S10vmtoolsd | 4 ++-- > package/openvpn/S60openvpn | 22 +++++++++++----------- > package/portmap/S13portmap | 4 ++-- > package/postgresql/S50postgresql | 4 ++-- > package/proftpd/S50proftpd | 4 ++-- > package/ptpd/S65ptpd | 4 ++-- > package/ptpd2/S65ptpd2 | 4 ++-- > package/pulseaudio/S50pulseaudio | 4 ++-- > package/python-web2py/S51web2py | 4 ++-- > package/radvd/S50radvd | 2 +- > package/redis/S50redis | 4 ++-- > package/rpcbind/S30rpcbind | 4 ++-- > package/rpi-userland/S94vcfiled | 4 ++-- > package/rsyslog/S01logging | 4 ++-- > package/samba/S91smb | 10 +++++----- > package/samba4/S91smb | 10 +++++----- > package/shairport-sync/S99shairport-sync | 4 ++-- > package/smstools3/S50smsd | 4 ++-- > package/squid/S97squid | 8 ++++---- > package/stunnel/S50stunnel | 4 ++-- > package/supervisor/S99supervisord | 4 ++-- > package/sysklogd/S01logging | 4 ++-- > package/targetcli-fb/S50target | 4 ++-- > package/tftpd/S80tftpd-hpa | 8 ++++---- > package/tinyhttpd/S85tinyhttpd | 6 +++--- > package/triggerhappy/S10triggerhappy | 4 ++-- > package/upmpdcli/S99upmpdcli | 4 ++-- > package/vsftpd/S70vsftpd | 4 ++-- > package/x11r7/xapp_xdm/S99xdm | 2 +- Impressive, I had no idea we had so many start scripts! Regards, Arnout > toolchain/helpers.mk | 4 ++-- > toolchain/toolchain-external/toolchain-external.mk | 4 ++-- > 74 files changed, 180 insertions(+), 180 deletions(-) -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF