Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] efl: fix framebuffer support
Date: Fri, 9 Oct 2015 23:32:36 +0200	[thread overview]
Message-ID: <56183274.3060402@openwide.fr> (raw)
In-Reply-To: <1444074105-2110-2-git-send-email-vicencb@gmail.com>

Hi Vicente,

Le 05/10/2015 21:41, Vicente Bergas a ?crit :
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
>  ...ecore_fb_private.h-define-EAPI-before-use.patch | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> 
> diff --git a/package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch b/package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> new file mode 100644
> index 0000000..6303930
> --- /dev/null
> +++ b/package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> @@ -0,0 +1,42 @@
> +ecore_fb_private.h: define EAPI before use
> +

Your patch needs probably a commit log and your SoB line, see:

http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches

Don't forget to add a link to the enlightenment mailing list where the initial
patch has been posted.
(http://sourceforge.net/p/enlightenment/mailman/message/34492801)

Also, it would be great if you can provide a git formatted patch in order to
ease the patch maintenance. (not mandatory though).

For now, I'll fixes that locally.

Best regards,
Romain

> +---
> + src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
> + 1 file changed, 17 insertions(+)
> +
> +diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
> +index f7dc0c6..f54c8d2 100644
> +--- a/src/lib/ecore_fb/ecore_fb_private.h
> ++++ b/src/lib/ecore_fb/ecore_fb_private.h
> +@@ -33,6 +33,20 @@
> + 
> + #include <Ecore_Fb.h>
> + 
> ++#ifdef EAPI
> ++# undef EAPI
> ++#endif
> ++
> ++#ifdef __GNUC__
> ++# if __GNUC__ >= 4
> ++#  define EAPI __attribute__ ((visibility("default")))
> ++# else
> ++#  define EAPI
> ++# endif
> ++#else
> ++# define EAPI
> ++#endif
> ++
> + /* ecore_fb_li.c */
> + struct _Ecore_Fb_Input_Device
> + {
> +@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
> + #define TS_GET_CAL 0x8014660a
> + #endif
> +   
> ++#undef EAPI
> ++#define EAPI
> ++
> + #endif
> +-- 
> +2.6.0
> +
> 

  reply	other threads:[~2015-10-09 21:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21  0:30 [Buildroot] [RFC 00/37] efl bump to 1.14.2 vj
2015-08-21  9:51 ` Romain Naour
2015-08-21 10:18   ` Romain Naour
2015-08-21 17:56   ` vj
2015-08-24 21:42     ` Romain Naour
2015-08-24 22:09       ` vj
2015-09-05 14:55         ` Romain Naour
2015-09-27  0:37           ` vj
2015-09-28 21:00             ` Romain Naour
2015-10-05 19:41               ` [Buildroot] efl: fix framebuffer support Vicente Bergas
2015-10-05 19:41                 ` Vicente Bergas
2015-10-09 21:32                   ` Romain Naour [this message]
2015-10-09 21:04                 ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56183274.3060402@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox