Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openal: New package
Date: Tue, 13 Oct 2015 18:07:40 +0100	[thread overview]
Message-ID: <561D3A5C.7060504@imgtec.com> (raw)
In-Reply-To: <561C0AD0.6050909@dawncrow.de>

Dear Andr? Hentschel,

thanks for your contribution. Your patch has one more issue apart from
the ones highlighted by Thomas. Please keep reading.

On 10/12/2015 08:32 PM, Andr? Hentschel wrote:
[snip]
> diff --git a/package/Config.in b/package/Config.in
> index 37d9cd0..767cb29 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -722,6 +722,7 @@ menu "Audio/Sound"
>  	source "package/opencore-amr/Config.in"
>  	source "package/opus/Config.in"
>  	source "package/opusfile/Config.in"
> +	source "package/openal/Config.in"

This list of packages is alphabetically ordered, therefore openal should
be higher. Please include that fix as well in the next version of your
patch.

Also remember to add the version number to the subject-prefix of your
patch, and provide a changelog between versions. This is explained here:

http://buildroot.org/downloads/manual/manual.html#submitting-patches
"21.5.2. Patch revision changelog"

Regards,

Vincent.

>  	source "package/portaudio/Config.in"
>  	source "package/speex/Config.in"
>  	source "package/taglib/Config.in"
[snip]

  parent reply	other threads:[~2015-10-13 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 19:32 [Buildroot] [PATCH] openal: New package André Hentschel
2015-10-12 19:47 ` Thomas Petazzoni
2015-10-13 17:07 ` Vicente Olivert Riera [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-03 17:21 André Hentschel
2015-10-04  8:12 ` Bernd Kuhls
2015-10-04 17:04   ` André Hentschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561D3A5C.7060504@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox