[Buildroot] [PATCH v2 1/1] package/ffmpeg: Disable rtmpdump support when PolarSSL is enabled

[Gustavo Zacarias <gustavo@zacarias.com.ar>]

On 15/10/15 19:02, Thomas Petazzoni wrote:

> Dear Bernd Kuhls,
>
> On Thu, 15 Oct 2015 21:55:21 +0200, Bernd Kuhls wrote:
>> Using rtmpdump with PolarSSL breaks ffmpeg configure:
>> /home/test/autobuild/instance-1/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/lib/librtmp.so: undefined reference to `havege_random'
>> /home/test/autobuild/instance-1/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/lib/librtmp.so: undefined reference to `havege_init'
>
> This indicates that polarssl doesn't provide all the symbols needed by
> librtmp.
>
> So the problem should not be fixed at the ffmpeg level, but at the
> librtmp level: any other package that will try to link with librtmp
> will have the same issue.

Hi Thomas, definitely...

> The fix should be done in rtmpdump.mk, by disabling the possibility of
> using polarssl as the crypto library. I guess it has to do with the API
> change of PolarSSL (Gustavo ?).

Those are part of the 1.2 API so no issues there.
However rtmpdump has severe issues with it's Makefile and the resulting 
librtmp.pc.
librtmp.pc.in says:

Requires: @CRYPTO_REQ@

The Makefile says (condensed):

CRYPTO=OPENSSL
#CRYPTO=GNUTLS
...
REQ_GNUTLS=gnutls,hogweed,nettle
REQ_OPENSSL=libssl,libcrypto
...
CRYPTO_REQ=$(REQ_$(CRYPTO))

Hence polarssl is never thrown into the pkgconfig fail, hence it will 
always fail.

So, as it is, rtmpdump is useless with polarssl even if it builds with 
it, so your fix is the right one unless rtmpdump is fixed.

Regards.