From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Naour Date: Mon, 26 Oct 2015 23:04:27 +0100 Subject: [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option In-Reply-To: <20151025144804.GJ11692@free.fr> References: <1445720476-21517-1-git-send-email-romain.naour@openwide.fr> <1445720476-21517-14-git-send-email-romain.naour@openwide.fr> <20151025144804.GJ11692@free.fr> Message-ID: <562EA36B.6020407@openwide.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Yann, All, Le 25/10/2015 15:48, Yann E. MORIN a ?crit : > Romain, All, > > On 2015-10-24 23:00 +0200, Romain Naour spake thusly: >> Like for webp format, add an option to enable the JPEG 2000 >> codec support in the efl libraries. > > Suddenly, I wonder why you added a bunch of image loaders in the first > patch adding libelf, but you add a few more such loaders in separate > patches. > > Can't you do either: > - introduce all of them as separate patches, or > - introduce all of them in the first patch adding libefl? > > Or is there an underlying good reason to do as you did? Yes there is a reason (good maybe), I wanted to add in the first patch all images loader that are already present in the previous version of efl package. So, I added new one in separate patches. Best regards, Romain > > Regards, > Yann E. MORIN. > >> Signed-off-by: Romain Naour >> --- >> v4: rename to libefl >> improve commit log >> --- >> package/efl/libefl/Config.in | 7 +++++++ >> package/efl/libefl/libefl.mk | 7 +++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in >> index e25911f..53adea2 100644 >> --- a/package/efl/libefl/Config.in >> +++ b/package/efl/libefl/Config.in >> @@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG >> This enables the loader code that loads png files using >> libpng. >> >> +config BR2_PACKAGE_LIBEFL_JP2K >> + bool "libevas jp2k loader" >> + select BR2_PACKAGE_OPENJPEG >> + help >> + This enables the loader code that loads jp2k files using >> + openjpeg. >> + >> config BR2_PACKAGE_LIBEFL_JPEG >> bool "libevas jpeg loader" >> help >> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk >> index 3a4aab1..e53470d 100644 >> --- a/package/efl/libefl/libefl.mk >> +++ b/package/efl/libefl/libefl.mk >> @@ -201,6 +201,13 @@ else >> LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no >> endif >> >> +ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y) >> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes >> +LIBEFL_DEPENDENCIES += openjpeg >> +else >> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no >> +endif >> + >> ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y) >> LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes >> LIBEFL_DEPENDENCIES += webp >> -- >> 2.4.3 >> >> _______________________________________________ >> buildroot mailing list >> buildroot at busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > -- Romain Naour OPEN WIDE Ing?nierie - Paris 23/25, rue Daviel| 75013 PARIS http://ingenierie.openwide.fr Le blog des technologies libres et embarqu?es : http://www.linuxembedded.fr