From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Wed, 28 Oct 2015 09:32:06 +0100 Subject: [Buildroot] [PATCH 3/3] package/git: Used curl-config program for target In-Reply-To: <20151028082327.GC13534@cruxbox> References: <1445893962-13338-1-git-send-email-repk@triplefau.lt> <1445893962-13338-4-git-send-email-repk@triplefau.lt> <563003C1.3000104@mind.be> <20151028082327.GC13534@cruxbox> Message-ID: <56308806.5040403@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 28-10-15 09:23, Remi Pommarel wrote: > On Wed, Oct 28, 2015 at 12:07:45AM +0100, Arnout Vandecappelle wrote: >> On 26-10-15 22:12, Remi Pommarel wrote: >>> Fix cross compilation by using curl-config script for target instead of the >>> one from host. >>> >>> Signed-off-by: Remi Pommarel >> >> Again, please patch configure.ac instead of configure. Otherwise, looks good to >> me. Though I didn't immediately understand why it wasn't necessary to add >> CURL_CONFIG to config.mak.in > > Ok I will use configure.ac patch instead. Git can be configured using > two ways, either using configure or using config.mak.in. I could have set > CURL_CONFIG in config.mak.in also but using the two methods at the same > time is redundant. Er, I'm pretty sure that configure will convert config.mak.in into config.mak.autogen. But it will append all the GIT_CONFIG_SUBST variables, which is not usual autotools idiom, that's why I was confused. Regards, Arnout -- Arnout Vandecappelle arnout dot vandecappelle at essensium dot com Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile) Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF