From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnout Vandecappelle <arnout@mind.be>
Date: Wed, 28 Oct 2015 22:00:07 +0100
Subject: [Buildroot] [PATCH v2] Makefile: Remove 'quiet' variable
In-Reply-To: <1444334617-23796-1-git-send-email-cedric.marie@openmailbox.org>
References: <1444334617-23796-1-git-send-email-cedric.marie@openmailbox.org>
Message-ID: <56313757.7080705@mind.be>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 08-10-15 22:03, C?dric Marie wrote:
> 'quiet' variable is set and exported, but it is not used. We can safely
> remove it.
> 
> This variable is inherited from the Makefile of the Linux kernel, and
> is not used in Buildroot.
> 
> In support/scripts/mkmakefile, 'quiet' value is checked, but the test
> is always true ('quiet' is never set to silent_), so the test can be
> removed as well.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> 
> ---
> Changes v1 -> v2:
>   - KBUILD_VERBOSE must not be removed, it is used for packages based
>     on Kbuild.
> 
> Title of PATCH v1 was:
> Makefile: Remove KBUILD_VERBOSE and quiet
> 
> In order to describe how the verbosity level is managed in different
> infrastructures, comments will be added in Makefile (suggested by Arnout).
> It will be provided in a separate patch.
> 
> Arnout also suggested not to export 'Q', which seems to be Buildroot
> internal. This will also be provided in a separate patch, if confirmed.
> ---
>  Makefile                   | 4 +---
>  support/scripts/mkmakefile | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 181d446..470ea65 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -226,14 +226,12 @@ ifndef KBUILD_VERBOSE
>  endif
>  
>  ifeq ($(KBUILD_VERBOSE),1)
> -  quiet =
>    Q =
>  ifndef VERBOSE
>    VERBOSE = 1
>  endif
>  export VERBOSE
>  else
> -  quiet = quiet_
>    Q = @
>  endif
>  
> @@ -245,7 +243,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
>  # kconfig uses CONFIG_SHELL
>  CONFIG_SHELL := $(SHELL)
>  
> -export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
> +export SHELL CONFIG_SHELL Q KBUILD_VERBOSE
>  
>  ifndef HOSTAR
>  HOSTAR := ar
> diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
> index 833be6a..37162a3 100755
> --- a/support/scripts/mkmakefile
> +++ b/support/scripts/mkmakefile
> @@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
>  then
>  	exit 0
>  fi
> -if [ "${quiet}" != "silent_" ]; then
> -	echo "  GEN     $2/Makefile"
> -fi
> +echo "  GEN     $2/Makefile"
>  
>  cat << EOF > $2/Makefile
>  # Automatically generated by $0: don't edit
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF