Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/9 v2] toolchain-external/blacfin: always force keeping hardlinks from archives
Date: Fri, 30 Oct 2015 11:51:21 +0100	[thread overview]
Message-ID: <56334BA9.60508@mind.be> (raw)
In-Reply-To: <5a706d0a2b7d76256a1883350e3e22ffcc3501ec.1445690712.git.yann.morin.1998@free.fr>

On 24-10-15 14:48, Yann E. MORIN wrote:
> Currently, for the blackfin external toolchains, we tell tar to extract
> files by dereferencing hard-links.
> 
> However, --hard-dereference has no impact when extracting archives in
> which there are hard-links.

 Took me a while to understand what you meant. How about:

However, --hard-dereference is only meaningful when creating an archive,
not when extracting it.

 With that:

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> 
> Drop this option.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  toolchain/toolchain-external/toolchain-external.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 4e12a1c..704ce2b 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -453,9 +453,9 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1)$(BR2_TOOLCHAIN_EXTERNAL_
>  define TOOLCHAIN_EXTERNAL_EXTRACT_CMDS
>  	mkdir -p $(TOOLCHAIN_EXTERNAL_INSTALL_DIR)
>  	$(call suitable-extractor,$(TOOLCHAIN_EXTERNAL_SOURCE)) $(DL_DIR)/$(TOOLCHAIN_EXTERNAL_SOURCE) | \
> -		$(TAR) --strip-components=3 --hard-dereference -C $(TOOLCHAIN_EXTERNAL_INSTALL_DIR) $(TAR_OPTIONS) -
> +		$(TAR) --strip-components=3 -C $(TOOLCHAIN_EXTERNAL_INSTALL_DIR) $(TAR_OPTIONS) -
>  	$(call suitable-extractor,$(TOOLCHAIN_EXTERNAL_EXTRA_DOWNLOADS)) $(DL_DIR)/$(TOOLCHAIN_EXTERNAL_EXTRA_DOWNLOADS) | \
> -		$(TAR) --strip-components=3 --hard-dereference -C $(TOOLCHAIN_EXTERNAL_INSTALL_DIR) $(TAR_OPTIONS) -
> +		$(TAR) --strip-components=3 -C $(TOOLCHAIN_EXTERNAL_INSTALL_DIR) $(TAR_OPTIONS) -
>  endef
>  else ifneq ($(TOOLCHAIN_EXTERNAL_SOURCE),)
>  # Normal handling of toolchain tarball extraction.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-10-30 10:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 12:48 [Buildroot] [PATCH 0/9 v2] toolchain/external: use generic extract commands (branch yem/extract-cmds) Yann E. MORIN
2015-10-24 12:48 ` [Buildroot] [PATCH 1/9 v2] core/pkg-generic: allow packages to exclude files when extracting Yann E. MORIN
2015-10-29 10:55   ` Vicente Olivert Riera
2015-10-29 11:13   ` Martin Bark
2015-10-24 12:48 ` [Buildroot] [PATCH 2/9 v2] toolchain-external/blacfin: always force keeping hardlinks from archives Yann E. MORIN
2015-10-30 10:51   ` Arnout Vandecappelle [this message]
2015-10-24 12:48 ` [Buildroot] [PATCH 3/9 v2] package/gcc: use generic extract commands Yann E. MORIN
2015-10-29 11:25   ` Vicente Olivert Riera
2015-10-24 12:48 ` [Buildroot] [PATCH 4/9 v2] toolchain/external: use generic extract commands (!blackfin case) Yann E. MORIN
2015-10-29 11:39   ` Vicente Olivert Riera
2015-10-24 12:48 ` [Buildroot] [PATCH 5/9 v2] toolchain/external: use generic extract commands (blackfin case) Yann E. MORIN
2015-10-24 12:48 ` [Buildroot] [PATCH 6/9 v2] toolchain/external: allow user to exclude files from custom toolchains Yann E. MORIN
2015-10-29 11:53   ` Vicente Olivert Riera
2015-10-24 12:48 ` [Buildroot] [PATCH 7/9 v2] toolchain/external: add MIPS Codescape MTI GNU Linux toolchain Yann E. MORIN
2015-10-24 12:49 ` [Buildroot] [PATCH 8/9 v2] toolchain/external: add MIPS Codescape IMG " Yann E. MORIN
2015-10-24 12:49 ` [Buildroot] [PATCH 9/9 v2] toolchain/external: Codescape toolchains also exist for x86_64 Yann E. MORIN
2015-10-29 12:10   ` Vicente Olivert Riera
2015-11-03 22:40 ` [Buildroot] [PATCH 0/9 v2] toolchain/external: use generic extract commands (branch yem/extract-cmds) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56334BA9.60508@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox