Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libtirpc: rpcgen is only built for host, don't install to target
Date: Tue, 3 Nov 2015 23:43:42 +0100	[thread overview]
Message-ID: <5639389E.9090209@mind.be> (raw)
In-Reply-To: <1446584983-29703-1-git-send-email-phil@zankapfel.net>

On 03-11-15 22:09, Phil Eichinger wrote:
> rpcgen is only used to generate headers needed for compilation.
> Move it to noinst_PROGRAMS otherwise you may end up with a host-arch
> binary in your target.
> 
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Note that nfs-utils-1.3.3 actually defines it in noinst_PROGRAMS.

 Regards,
 Arnout

> ---
>  package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch
> index ad14312..1cf8614 100644
> --- a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch
> +++ b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch
> @@ -87,7 +87,7 @@ index 0000000..2277b6f
>  +	$(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD)
>  +LINK = $(CC_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(AM_LDFLAGS) $(LDFLAGS_FOR_BUILD) -o $@
>  +
> -+bin_PROGRAMS = rpcgen
> ++noinst_PROGRAMS = rpcgen
>  +
>  +rpcgen_SOURCES = \
>  +	rpc_clntout.c \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-11-03 22:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 21:09 [Buildroot] [PATCH 1/1] libtirpc: rpcgen is only built for host, don't install to target Phil Eichinger
2015-11-03 22:43 ` Arnout Vandecappelle [this message]
2015-11-03 22:49 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5639389E.9090209@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox