[Buildroot] [PATCH v3 11/13] package/dhcp: systemd: support IPv6 lease file

["Benoît Thébaudeau" <benoit@wsystem.com>]

Maxime, all,

On 04/11/2015 11:21, Maxime Hadjinlian wrote:
> Hi Benoit, all
> 
> On Sun, Oct 25, 2015 at 2:59 AM, Beno?t Th?baudeau <benoit.thebaudeau.dev at gmail.com <mailto:benoit.thebaudeau.dev@gmail.com>> wrote:
> 
>     The IPv6 lease file has a different name.
> 
>     Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau.dev at gmail.com <mailto:benoit.thebaudeau.dev@gmail.com>>
> 
>     ---
>     Changes v2 -> v3: new patch.
>     ---
>      package/dhcp/dhcp.mk <http://dhcp.mk> | 2 ++
>      1 file changed, 2 insertions(+)
> 
>     diff --git a/package/dhcp/dhcp.mk <http://dhcp.mk> b/package/dhcp/dhcp.mk <http://dhcp.mk>
>     index c05e694..3aa1577 100644
>     --- a/package/dhcp/dhcp.mk <http://dhcp.mk>
>     +++ b/package/dhcp/dhcp.mk <http://dhcp.mk>
>     @@ -83,6 +83,8 @@ define DHCP_INSTALL_INIT_SYSTEMD
>                     $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
>             echo "f /var/lib/dhcp/dhcpd.leases - - - - -" >> \
>                     $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
>     +       echo "f /var/lib/dhcp/dhcpd6.leases - - - - -" >> \
>     +               $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
>      endef
>      endif
> 
> Reviewed-by: "Maxime Hadjinlian" <maxime.hadjinlian at gmail.com <mailto:maxime.hadjinlian@gmail.com>>
> 
> A question though, from the manual page of dhcpd, by default it starts as an IPv6 server should we have, two services one with '-4' and one with '-6' ? And it's left to the user to specify it in the "$OPTIONS" ? Maybe this should be mentioned somewhere ?

'-4' is the default, not '-6'. A single instance of dhcpd cannot be run with
both '-4' and '-6'. I don't know if it's possible (or desirable) to safely run
simultaneously two instances of dhcpd, one with '-4' and the other one with
'-6'.

"$OPTIONS" is designed exactly for such things. Users should read the man page
of dhcpd to know what may fit in there.

Best regards,
Beno?t