[Buildroot] [PATCH] package/gauche: remove unnecessary files for target, fix a typo

From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gauche: remove unnecessary files for target, fix a typo
Date: Tue, 10 Nov 2015 21:54:35 +0100	[thread overview]
Message-ID: <5642598B.2000509@mind.be> (raw)
In-Reply-To: <201511100922.tAA9Ml77000486@ms-omx02.plus.so-net.ne.jp>

 Hi Hiroshi,

 The subject line is a bit long, you could make it:

package/gauche: remove unnecessary files for target

While we're at it, also fix a typo.

On 10-11-15 10:22, Hiroshi Kawashima wrote:
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> ---
> diff --git a/package/gauche/gauche.mk b/package/gauche/gauche.mk
> index b887c6a..8406774 100644
> --- a/package/gauche/gauche.mk
> +++ b/package/gauche/gauche.mk
> @@ -4,7 +4,8 @@
>  #
>  ################################################################################
>  
> -GAUCHE_VERSION = 0.9.4
> +GAUCHE_VERSION_MAJOR = 0.9
> +GAUCHE_VERSION = $(GAUCHE_VERSION_MAJOR).4
>  GAUCHE_SOURCE = Gauche-$(GAUCHE_VERSION).tgz
>  GAUCHE_SITE = http://downloads.sourceforge.net/project/gauche/Gauche
>  GAUCHE_LICENSE = BSD-3c, Boehm-gc, SRFI (srfi-11.scm), reload (reload.scm)
> @@ -23,10 +24,24 @@ endif
>  # Detection of c99 support in configure fails without WCHAR. To enable
>  # automatic detection of c99 support by configure, we need to enable
>  # WCHAR in toolchain. But actually we do not need WCHAR at gauche
> -# runtime. So reuesting WCHAR in toolchain just for automatic detection
> +# runtime. So requesting WCHAR in toolchain just for automatic detection
>  # will be overkill. To solve this, explicitly -std=gnu99 is specified
>  # here.
>  GAUCHE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
>  
> +define GAUCHE_REMOVE_UNNEEDED
> +	for i in gauche-config gauche-install gauche-package ; do \
> +		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> +		rm -f $(TARGET_DIR)/usr/lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/$(GNU_TARGET_NAME)/$$i ; \
> +	done
> +	for i in gencomp genstub precomp ; do \
> +		rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/lib/$$i ; \
> +	done
> +	rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/aclocal.m4
> +	rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/template.*
> +	rm -fr $(TARGET_DIR)/usr/lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/include

 This cleanup is quite complicated and I wonder if it is really worth it. For
space, the impact is really small compared to the 3MB of libs and .scm files
installed by the package. Even the ones in /usr/bin I'm not sure if it's worth
to remove them.

 Thomas, what do you think?

 Regards,
 Arnout

> +endef
> +GAUCHE_POST_INSTALL_TARGET_HOOKS += GAUCHE_REMOVE_UNNEEDED
> +
>  $(eval $(host-autotools-package))
>  $(eval $(autotools-package))
> ============================================================
>     Hiroshi Kawashima
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF