Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] core/pkg-autotools: align host configure commands to target one
Date: Sun, 22 Nov 2015 21:46:40 +0100	[thread overview]
Message-ID: <565229B0.7030603@mind.be> (raw)
In-Reply-To: <f288b50c4267ceb0ca24aa1a7937d8f5fa894ed5.1448202976.git.yann.morin.1998@free.fr>

On 22-11-15 15:39, Yann E. MORIN wrote:
> The host configure commands are not indented the same way as the target
> ones. Besides, there are leading spaces (instead of TABs) on one line.
> 
> Replicate the same indentation as used for the target commands.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 [Verified that it's whitespace only change.]


 Regards,
 Arnout

> ---
>  package/pkg-autotools.mk | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index 4787914..502eeea 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -214,12 +214,12 @@ else
>  # installed.
>  define $(2)_CONFIGURE_CMDS
>  	(cd $$($$(PKG)_SRCDIR) && rm -rf config.cache; \
> -	        $$(HOST_CONFIGURE_OPTS) \
> -		CFLAGS="$$(HOST_CFLAGS)" \
> -		LDFLAGS="$$(HOST_LDFLAGS)" \
> -		$$($$(PKG)_CONF_ENV) \
> -		CONFIG_SITE=/dev/null \
> -		./configure \
> +	$$(HOST_CONFIGURE_OPTS) \
> +	CFLAGS="$$(HOST_CFLAGS)" \
> +	LDFLAGS="$$(HOST_LDFLAGS)" \
> +	$$($$(PKG)_CONF_ENV) \
> +	CONFIG_SITE=/dev/null \
> +	./configure \
>  		--prefix="$$(HOST_DIR)/usr" \
>  		--sysconfdir="$$(HOST_DIR)/etc" \
>  		--localstatedir="$$(HOST_DIR)/var" \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-11-22 20:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 14:39 [Buildroot] [PATCH 0/3] core+gcc: align configure commands (branch yem/quickies-for-master) Yann E. MORIN
2015-11-22 14:39 ` [Buildroot] [PATCH 1/3] core/pkg-autotools: align host configure commands to target one Yann E. MORIN
2015-11-22 20:46   ` Arnout Vandecappelle [this message]
2015-11-23 17:38   ` Thomas Petazzoni
2015-11-23 17:51     ` Yann E. MORIN
2015-11-23 17:55       ` Yann E. MORIN
2015-11-23 20:09       ` Thomas Petazzoni
2015-11-23 20:51         ` Yann E. MORIN
2015-11-22 14:39 ` [Buildroot] [PATCH 2/3] package/gcc: comment on why we override the generic configure commands Yann E. MORIN
2015-11-22 15:11   ` Jérôme Pouiller
2015-11-22 20:48   ` Arnout Vandecappelle
2015-11-23 17:38   ` Thomas Petazzoni
2015-11-22 14:39 ` [Buildroot] [PATCH 3/3] package/gcc: align gcc-final configure-cmds to the generic ones Yann E. MORIN
2015-11-22 20:59   ` Arnout Vandecappelle
2015-11-22 21:02     ` Yann E. MORIN
2015-11-23 20:14   ` Thomas Petazzoni
2015-11-24 18:39     ` Yann E. MORIN
2015-12-29 22:06   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565229B0.7030603@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox