Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2015-11-22
Date: Tue, 24 Nov 2015 10:33:04 +0000	[thread overview]
Message-ID: <56543CE0.6050002@imgtec.com> (raw)
In-Reply-To: <565380A0.8070101@openwide.fr>

Hi Romain,

On 23/11/15 21:09, Romain Naour wrote:
> Hello,
> 
>>       x86_64 |                  lvm2-2.02.132 | NOK | http://autobuild.buildroot.net/results/964b5909dbac97d56b87e22e5141d62c54eba893/
> 
> commands/toolcontext.c: In function 'create_toolcontext':
> commands/toolcontext.c:1795:10: error: assignment of read-only variable 'stdin'
>     stdin = new_stream;
> 
> This is a musl issue and generally fixed by using freopen(). See [1] [2].
> 
> There is a patch from alpinelinux [3] but I'm wondering if it could be simpler
> to get ride of _reopen_stream() an use freopen() instead.
> 
> Vincente, what do you think ?

you told me in the IRC that this patch could affect other C libraries,
so, my opinion is that it would be better to work with upstream and fix
the problem there, and then backport the fix into Buildroot.

Regards,

Vincent.

> Best regards,
> Romain
> 
> [1]
> https://github.com/doughdemon/fdupes/commit/fe2d8334bfa28ff05fa1a2ffe8555a19b41be0ea
> [2] https://github.com/adrianlopezroche/fdupes/pull/31
> [3]
> http://git.alpinelinux.org/cgit/aports/tree/main/lvm2/fix-stdio-usage.patch?h=v3.2.3
> 

      reply	other threads:[~2015-11-24 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23  7:30 [Buildroot] [autobuild.buildroot.net] Build results for 2015-11-22 Thomas Petazzoni
2015-11-23 21:09 ` Romain Naour
2015-11-24 10:33   ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56543CE0.6050002@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox