From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 1 Dec 2015 22:37:15 +0100 Subject: [Buildroot] [PATCH v6] package/unscd: new package In-Reply-To: <1448982954-5055-1-git-send-email-rdkehn@yahoo.com> References: <1448982954-5055-1-git-send-email-rdkehn@yahoo.com> Message-ID: <565E130B.7090201@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Doug, Even though it's already v6 I still have some comments :-( On 01-12-15 16:15, Doug Kehn wrote: > A daemon which handles passwd, group and host lookups for running > programs and caches the results for the next query. You only need this > package if you are using slow Name Services like LDAP, NIS or NIS+. > > This particular NSCD is a complete rewrite of the GNU glibc nscd which > is a single threaded server process which offloads all NSS lookups to > worker children; cache hits are handled by the parent, and only cache > misses start worker children, making the parent immune to resource > leaks, hangs, and crashes in NSS libraries. > > It should mostly be a drop-in replacement for existing installs using > nscd. This explanation is not really relevant for the commit log. Just keep the first sentence. All this text should be present in the package help text, however. It would be good however to explain in the commit log that glibc's nscd is not installed by buildroot at the moment, and why it only works with glibc. > > Cc: Yann E. MORIN > Cc: Arnout Vandecappelle > Cc: Thomas Petazzoni > Signed-off-by: Doug Kehn > --- > Changes v5 -> v6 > - Remove toolchain patch/BR2_GLIBC_NSCD (Thomas). > - Change source site from Debian to upstream (Thomas). > - Update to version 0.52 (Thomas). > Changes v4 -> v5 > - Reincorporate $(APPLY_PATCHES) suggestion after update by Arnout. > Changes v3 -> v4 > - Incorporate feedback/suggestions by Yann and Maxime. > Changes v2 -> v3 > - Remove trailing '/' from UNSCD_SITE. > - Whitespace cleanup. > Changes v1 -> v2 > - Incorporate feedback/suggestions by Yann (from nss-pam-ldapd patch). > --- > package/unscd/Config.in | 8 ++++++ > package/unscd/S46unscd | 24 ++++++++++++++++++ > package/unscd/nscd.conf | 65 ++++++++++++++++++++++++++++++++++++++++++++++++ > package/unscd/unscd.hash | 2 ++ > package/unscd/unscd.mk | 35 ++++++++++++++++++++++++++ You forgot to update package/Config.in. > 5 files changed, 134 insertions(+) > create mode 100644 package/unscd/Config.in > create mode 100644 package/unscd/S46unscd > create mode 100644 package/unscd/nscd.conf > create mode 100644 package/unscd/unscd.hash > create mode 100644 package/unscd/unscd.mk > > diff --git a/package/unscd/Config.in b/package/unscd/Config.in > new file mode 100644 > index 0000000..937aeb2 > --- /dev/null > +++ b/package/unscd/Config.in > @@ -0,0 +1,8 @@ > +config BR2_PACKAGE_UNSCD > + bool "unscd" > + depends on BR2_TOOLCHAIN_USES_GLIBC > + help > + Micro Name Service Caching Daemon So move the stuff that was in the commit log here. Don't forget to wrap it at 72 columns (where the tab+2spaces counts as 10 characters). Also, please add an upstream URL where people can go for more info. > + > +comment "unscd needs an (e)glibc toolchain" > + depends on !BR2_TOOLCHAIN_USES_GLIBC [snip] > diff --git a/package/unscd/nscd.conf b/package/unscd/nscd.conf > new file mode 100644 > index 0000000..fe77d05 > --- /dev/null > +++ b/package/unscd/nscd.conf > @@ -0,0 +1,65 @@ > +# This file is currently taken verbatim from the version distributed > +# with GNU glibc's nscd with unused configurations removed This comment should also be part of the commit message rather than being part of this file. > +# > +# /etc/nscd.conf > +# > +# An example Name Service Cache config file. This file is needed by nscd. > +# > +# Legal entries are: > +# > +# logfile > +# debug-level > +# threads > +# max-threads > +# server-user > +# server-user is ignored if nscd is started with -S parameters > +# stat-user (ignored; any user can stat) > +# reload-count (ignored; unscd should never crash) > +# paranoia (ignored) > +# restart-interval (ignored; unscd should never crash) I thought you removed the unused entries? :-) > +# > +# enable-cache > +# positive-time-to-live