From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Ceresoli Date: Thu, 3 Dec 2015 18:10:18 +0100 Subject: [Buildroot] [PATCH 03/51] package/gcc: align gcc-final configure-cmds to the generic ones In-Reply-To: References: Message-ID: <5660777A.9030407@lucaceresoli.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann, Yann E. MORIN wrote: > Since 7d6c79 (Compile static versions of gcc libraries) was applied, the > generic configure commands have been updated, but those changes have not > been propagated to the gcc-final custom configure commands. > > Update the gcc-final custom configure commands to better match the > generic ones. > > We do not propagate --disable-dependency-tracking because it breaks the > build, and --enable-shared (because of 169141a). > > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > --- > package/gcc/gcc-final/gcc-final.mk | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk > index dbdb615..53199c3 100644 > --- a/package/gcc/gcc-final/gcc-final.mk > +++ b/package/gcc/gcc-final/gcc-final.mk > @@ -36,16 +36,31 @@ HOST_GCC_FINAL_PRE_CONFIGURE_HOOKS += HOST_GCC_CONFIGURE_SYMLINK > # > # So we must completely override the generic commands and provide our own. > # > +# Except for --disable-dependency-tracking which breaks the build, and > +# --enable-shared (see 169141a, gcc-final: disable shared build for > +# static), we reproduce the exact same command as the autotools infra > +# uses. > +# > define HOST_GCC_FINAL_CONFIGURE_CMDS > (cd $(HOST_GCC_FINAL_SRCDIR) && rm -rf config.cache; \ > - $(HOST_CONFIGURE_OPTS) \ > - CFLAGS="$(HOST_CFLAGS)" \ > - LDFLAGS="$(HOST_LDFLAGS)" \ > - $(HOST_GCC_FINAL_CONF_ENV) \ > - ./configure \ > + $(HOST_CONFIGURE_OPTS) \ > + CFLAGS="$(HOST_CFLAGS)" \ > + LDFLAGS="$(HOST_LDFLAGS)" \ > + $(HOST_GCC_FINAL_CONF_ENV) \ > + CONFIG_SITE=/dev/null \ With the indentation cleanup, the CONFIG_SITE addition might be unnoticed (it did to me, at first). I suggest you mention its addition in the commit message and reference the originating commit: ------------8<-------------- CONFIG_SITE from commit f8d4fe3 ("package/pkg-autotools: don't use config.site when cross-compiling"). ------------8<-------------- With that added (and even without): Reviewed-by: Luca Ceresoli [Tested building qemu_arm_versatile_defconfig] Tested-by: Luca Ceresoli -- Luca