From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Ceresoli Date: Thu, 3 Dec 2015 18:13:07 +0100 Subject: [Buildroot] [PATCH 09/51] core/pkg-virtual: ignore from legal-info output In-Reply-To: <2788d5c56e3bbcb579972f9e81003d0625dfefa3.1448289515.git.yann.morin.1998@free.fr> References: <2788d5c56e3bbcb579972f9e81003d0625dfefa3.1448289515.git.yann.morin.1998@free.fr> Message-ID: <56607823.40409@lucaceresoli.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann, Yann E. MORIN wrote: > Virtual packages really have nothing to save for legal-info, so we just > ignore them. > > Currently, packages are only extracted if they define _LICENSE_FILES. > Follow-up patches will always extract and patch non-ignored packages, so > we would potentially see spurious "extracting" and "patching" messages > for virtual packages on the console, which would be a bit strange. > Ignoring virtual packages will get us a cleaner log. > > Signed-off-by: "Yann E. MORIN" > Cc: Luca Ceresoli > Cc: Thomas Petazzoni > --- > docs/manual/adding-packages-virtual.txt | 3 +++ > package/pkg-virtual.mk | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/docs/manual/adding-packages-virtual.txt b/docs/manual/adding-packages-virtual.txt > index a5f17a2..11a497d 100644 > --- a/docs/manual/adding-packages-virtual.txt > +++ b/docs/manual/adding-packages-virtual.txt > @@ -56,6 +56,9 @@ The +.mk+ for the virtual package should just evaluate the +virtual-package+ mac > The ability to have target and host packages is also available, with the > +host-virtual-package+ macro. > > +.Note: > +Virtual packages are automatically ignored when generating the +legal-info+ output. > + > ==== Provider's +Config.in+ file > > When adding a package as a provider, only the +Config.in+ file requires some > diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk > index 9c68b51..1471b95 100644 > --- a/package/pkg-virtual.mk > +++ b/package/pkg-virtual.mk > @@ -57,6 +57,8 @@ endif > # Add dependency against the provider > $(2)_DEPENDENCIES += $$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2))) > > +$(2)_REDISTRIBUTE = IGNORE > + Ack on the idea, but of course the patch shall be re-written to use the boolean variables instead. -- Luca