Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency
Date: Fri, 4 Dec 2015 00:35:56 +0100	[thread overview]
Message-ID: <5660D1DC.4010509@mind.be> (raw)
In-Reply-To: <f37416a8d0f491f30efbc89ddd3a2ce82e56b65c.1449181275.git.yann.morin.1998@free.fr>

On 03-12-15 23:22, Yann E. MORIN wrote:
> The gawk debugger can optionally use readline for user input during
> the debugging session (for the usual autocompletion and stuff).
> 
> Enable readline support when the readline package is enabled; let
> ./configure automatically find it. Forcibly disable readline support
> when the readline package is disabled.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <jacmet@uclibc.org>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>  package/gawk/gawk.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
> index 74c1fe4..4145025 100644
> --- a/package/gawk/gawk.mk
> +++ b/package/gawk/gawk.mk
> @@ -23,6 +23,13 @@ else
>  GAWK_CONF_OPTS += --without-mpfr
>  endif
>  
> +# When enabled, let ./configure find it automatically

 Same thing about the comment.

 Regards,
 Arnout

> +ifeq ($(BR2_PACKAGE_READLINE),y)
> +GAWK_DEPENDENCIES += readline
> +else
> +GAWK_CONF_OPTS += --without-readline
> +endif
> +
>  # We don't have a host-busybox, and we don't want to use readline or mpfr
>  HOST_GAWK_DEPENDENCIES =
>  
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

      reply	other threads:[~2015-12-03 23:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 22:22 [Buildroot] [PATCH 0/2] package/gawk: handle optional dependencies on mpfr and readline (branch yem/host-gawk) Yann E. MORIN
2015-12-03 22:22 ` [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency Yann E. MORIN
2015-12-03 23:35   ` Arnout Vandecappelle
2015-12-05 16:08     ` Yann E. MORIN
2015-12-05 17:25       ` Arnout Vandecappelle
2015-12-03 22:22 ` [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency Yann E. MORIN
2015-12-03 23:35   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660D1DC.4010509@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox