From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Sat, 5 Dec 2015 17:41:49 +0100 Subject: [Buildroot] [PATCH 1/4] docs/website: fixing html tidy errors and warnings In-Reply-To: <1449213674-11333-2-git-send-email-angelo.compagnucci@gmail.com> References: <1449213674-11333-1-git-send-email-angelo.compagnucci@gmail.com> <1449213674-11333-2-git-send-email-angelo.compagnucci@gmail.com> Message-ID: <566313CD.7020100@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 04-12-15 08:21, Angelo Compagnucci wrote: > This patch makes tidy html checker happy. Can you specify a bit more clearly how you got here? Like, the command line of htmltidy that generated errors, the number of errors it gave, and the number of errors still left after this patch. I've tried to run tidy and after this series it still gives a few hundred errors... Please also specify which type of errors you corrected. Also, if you've used some script to automate some of the changes, please write down how you did that. The reason for all of the above is that the patch is much too large to understand what really happens, so you need to provide as much detail as possible in the commit log. > > Signed-off-by: Angelo Compagnucci > --- > docs/website/docs.html | 20 ++++++++--------- > docs/website/download.html | 39 ++++++++++++++++---------------- > docs/website/header.html | 16 +++++++------- > docs/website/index.html | 24 ++++++++++---------- > docs/website/news.html | 55 +++++++++++++++++++++++----------------------- > docs/website/sponsors.html | 26 ++++++++++++---------- > docs/website/support.html | 10 ++++----- > 7 files changed, 96 insertions(+), 94 deletions(-) > > diff --git a/docs/website/docs.html b/docs/website/docs.html > index 9cee36d..4335796 100644 > --- a/docs/website/docs.html > +++ b/docs/website/docs.html > @@ -16,15 +16,15 @@ >
>
>
> - > + Does tidy or some other coding style require a space before the /> ? It looks strange to me... >
>
[snip] > @@ -90,21 +90,21 @@ >
>
Repository
>
> -

The buildroot repository can be browsed online through cgit at > +

The buildroot repository can be browsed online through cgit at > http://git.buildroot.net/buildroot. > To grab a copy of the repository use

> > >
> - value="git clone git://git.buildroot.net/buildroot" type="text" readonly> > + value="git clone git://git.buildroot.net/buildroot" type="text" readonly /> Er, space-tab-/> looks *really* strange. > > > > -

> +

And here you don't have a space before />. > >

> Or if you're behind a firewall blocking git: > @@ -116,34 +116,35 @@ > > > > -


> +

> >

> > Please use the native git protocol if at all possible, as it's a lot > - more efficient than HTTP. > + more efficient than HTTP.

It's strange to have the

on a separate line and the

directly after the final character of the paragraph. But since patch 4/4 changes that again, it doesn't matter. [snip] > diff --git a/docs/website/news.html b/docs/website/news.html > index 89c5062..f1961bf 100644 > --- a/docs/website/news.html > +++ b/docs/website/news.html [snip] > @@ -2593,7 +2592,7 @@ >
>
>
> -

> +

new Logo

This is an actual bugfix so should be in a separate high-priority patch. >

27 March 2009

>

>
> diff --git a/docs/website/sponsors.html b/docs/website/sponsors.html > index db50e37..801bca9 100644 > --- a/docs/website/sponsors.html > +++ b/docs/website/sponsors.html > @@ -14,7 +14,7 @@ >
>
> > - > + google logo I think it's better if the alt text doesn't describe what is missing, but really replaces the image. So in this case: "Google". It would be good to view it without images to verify that it looks OK. > >
>
> @@ -33,8 +33,8 @@ >
>
>
> - > - > + What's wrong with http://mind.be? And why don't you treat Google the same way? :-) > + mind logo "Mind", or even better "Essensium/Mind" (lot's of space here). > >
>
> @@ -68,7 +68,7 @@ >
>
> > - > + minid logo "Mind". Definitely not "minid". > >
>
> @@ -87,7 +87,7 @@ >
>
>

> -

> + google logo

Google >
>
>

Google provided the > @@ -103,7 +103,7 @@ >

>
>

> -

> + imgtec logo

Imagination Technologies etc. etc. [snip] > @@ -217,5 +217,7 @@ >
>
>
> +
> +
Wow, divide and conquer I guess? :-) > > > diff --git a/docs/website/support.html b/docs/website/support.html > index 2f16efe..6f3fb06 100644 > --- a/docs/website/support.html > +++ b/docs/website/support.html > @@ -16,7 +16,7 @@ >
>
>
> - > + irc icon "IRC" >
>
>

The Buildroot IRC channel is > @@ -36,7 +36,7 @@ >

>
>
> - > + mailing list icon Not much space here, so "Mail". >
>
>

The mailing list is for discussion and > @@ -56,8 +56,8 @@ > before.

> >
> - > - > + > + > >
>
> @@ -72,7 +72,7 @@ >
>
>
> - > + bug tracker icon Again not much space, so "Bugs". Regards, Arnout >
>
>

If you encounter any problem while using Buildroot, you can use the > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF