Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Hentschel" <nerv@dawncrow.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wine: fix sane related build failure
Date: Mon, 7 Dec 2015 20:42:25 +0100	[thread overview]
Message-ID: <5665E121.8010000@dawncrow.de> (raw)
In-Reply-To: <5662F947.6090900@mind.be>

Am 05.12.2015 um 15:48 schrieb Arnout Vandecappelle:
> On 04-12-15 17:52, Andr? Hentschel wrote:
>> Hi Thomas,
>>
>> Moving this discussion to the correct thread...
>> I meanwhile submitted https://bugs.winehq.org/show_bug.cgi?id=39660 which didn't caught much attention yet.
>> But I looked at it myself and I think I found a way to avoid patching Wine.
>> Wines configure exposes special COMPONENT_CFLAGS and COMPONENT_LIBS variables which get prioritized over "guessed" tools.
>> What's your opinion on this (afaict it works):
>>
>>
>> diff --git a/package/wine/wine.mk b/package/wine/wine.mk
>> index 38576db..e29d616 100644
>> --- a/package/wine/wine.mk
>> +++ b/package/wine/wine.mk
>> @@ -173,8 +173,9 @@ endif
>>  
>>  ifeq ($(BR2_PACKAGE_SANE_BACKENDS),y)
>>  WINE_CONF_OPTS += --with-sane
>> +WINE_CONF_OPTS += SANE_CFLAGS="`$(STAGING_DIR)/usr/bin/sane-config --cflags 2>/dev/null`"
>> +WINE_CONF_OPTS += SANE_LIBS="`$(STAGING_DIR)/usr/bin/sane-config --ldflags 2>/dev/null`"
>>  WINE_DEPENDENCIES += sane-backends
>> -WINE_CONF_ENV += SANE_CONFIG=$(STAGING_DIR)/usr/bin/sane-config
>>  else
>>  WINE_CONF_OPTS += --without-sane
>>  endif
> 
>  Looks good to me. However, doesn't sane install a pkg-config file as well? I'd
> prefer to use that one then.

Thx for the hint, but this is closer to what Wine would do, seems somewhat saver to me and I would stick to this approach if it's not a total NoGo

      reply	other threads:[~2015-12-07 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-05 11:15 [Buildroot] [PATCH] wine: fix sane related build failure Thomas Petazzoni
2015-07-05 14:32 ` Yann E. MORIN
2015-07-05 15:18 ` Thomas Petazzoni
2015-12-04 16:52 ` André Hentschel
2015-12-05 14:48   ` Arnout Vandecappelle
2015-12-07 19:42     ` André Hentschel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665E121.8010000@dawncrow.de \
    --to=nerv@dawncrow.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox