From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 07/13 v2] core/legal-info: add package version to license directory
Date: Wed, 16 Dec 2015 15:21:39 +0100 [thread overview]
Message-ID: <56717373.2060408@lucaceresoli.net> (raw)
In-Reply-To: <24da1c95e17ef8f5cbbcb47c8688178e45695d83.1450031251.git.yann.morin.1998@free.fr>
Dear Yann,
Yann E. MORIN wrote:
> Now that we save the source archives in a directory named after the
> package and its version, do the same for the license files, for
> consistency.
>
> It has a not-so-bad side-effect of also saving the version string in
> the all-licenses list.
>
> The only (small) side-efect, is that the warnings about undefined
efect -> effect
> _LICENSE_FILES now contains the version string, too. That's unavoidable,
> since that's what is stored in the legal report.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
> Changes v1 -> v2:
> - s/drawback/side-effect/ (Luca)
> ---
> package/pkg-generic.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 3b6240a..9b9a27f 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -806,10 +806,10 @@ ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
> # is that the license still applies to the files distributed as part
> # of the rootfs, even if the sources are not themselves redistributed.
> ifeq ($$(call qstrip,$$($(2)_LICENSE_FILES)),)
> - @$$(call legal-license-nofiles,$$($(2)_RAWNAME),$$(call UPPERCASE,$(4)))
> - @$$(call legal-warning-pkg,$$($(2)_RAWNAME),cannot save license ($(2)_LICENSE_FILES not defined))
> + @$$(call legal-license-nofiles,$$($(2)_RAWNAME_VERSION),$$(call UPPERCASE,$(4)))
> + @$$(call legal-warning-pkg,$$($(2)_RAWNAME_VERSION),cannot save license ($(2)_LICENSE_FILES not defined))
> else
> - @$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep))
> + @$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME_VERSION),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep))
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
next prev parent reply other threads:[~2015-12-16 14:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 18:35 [Buildroot] [PATCH 0/13 v2] legal-info improvements and completeness (branch yem/legal-2) Yann E. MORIN
2015-12-13 18:35 ` [Buildroot] [PATCH 01/13 v2] core/legal-info: update the legal-info report header Yann E. MORIN
2015-12-16 22:20 ` Arnout Vandecappelle
2015-12-13 18:35 ` [Buildroot] [PATCH 02/13 v2] core/pkg-utils: add macro to hardlink-or-copy Yann E. MORIN
2015-12-16 22:21 ` Arnout Vandecappelle
2015-12-13 18:35 ` [Buildroot] [PATCH 03/13 v2] core/legal-info: use the macro to install source archives Yann E. MORIN
2015-12-16 22:23 ` Arnout Vandecappelle
2015-12-13 18:35 ` [Buildroot] [PATCH 04/13 v2] core/legal-info: ensure legal-info works in off-line mode Yann E. MORIN
2015-12-16 11:30 ` Luca Ceresoli
2015-12-16 22:47 ` Luca Ceresoli
2015-12-16 23:05 ` Yann E. MORIN
2015-12-16 23:09 ` Arnout Vandecappelle
2015-12-16 23:13 ` Yann E. MORIN
2015-12-16 23:19 ` Arnout Vandecappelle
2015-12-18 22:11 ` Yann E. MORIN
2015-12-18 22:30 ` Yann E. MORIN
2015-12-13 18:35 ` [Buildroot] [PATCH 05/13 v2] core/pkg-generic: add variable to store the package rawname-version Yann E. MORIN
2015-12-16 12:07 ` Luca Ceresoli
2015-12-16 23:44 ` Arnout Vandecappelle
2015-12-13 18:35 ` [Buildroot] [PATCH 06/13 v2] core/legal-info: install source archives in their own sub-dir Yann E. MORIN
2015-12-16 23:56 ` Arnout Vandecappelle
2015-12-18 22:53 ` Yann E. MORIN
2015-12-19 0:02 ` Arnout Vandecappelle
2015-12-13 18:35 ` [Buildroot] [PATCH 07/13 v2] core/legal-info: add package version to license directory Yann E. MORIN
2015-12-16 14:21 ` Luca Ceresoli [this message]
2015-12-13 18:35 ` [Buildroot] [PATCH 08/13 v2] core/apply-patches: store full path of applied patches Yann E. MORIN
2015-12-17 10:44 ` Luca Ceresoli
2015-12-13 18:35 ` [Buildroot] [PATCH 09/13 v2] core/legal-info: also save patches Yann E. MORIN
2015-12-17 10:45 ` Luca Ceresoli
2015-12-18 23:07 ` Yann E. MORIN
2015-12-13 18:35 ` [Buildroot] [PATCH 10/13 v2] core/legal-info: also save extra downloads Yann E. MORIN
2015-12-17 10:57 ` Luca Ceresoli
2015-12-13 18:35 ` [Buildroot] [PATCH 11/13 v2] core/legal-info: generate a hash of all saved files Yann E. MORIN
2015-12-13 18:35 ` [Buildroot] [PATCH 12/13 v2] core/legal-info: allow ignoring packages from the legal-info Yann E. MORIN
2015-12-13 18:35 ` [Buildroot] [PATCH 13/13 v2] core/pkg-virtual: ignore from legal-info output Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56717373.2060408@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox