From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Thu, 17 Dec 2015 00:09:41 +0100 Subject: [Buildroot] [PATCH 04/13 v2] core/legal-info: ensure legal-info works in off-line mode In-Reply-To: <20151216230503.GB3448@free.fr> References: <82f1af6280a8c913d3df331813dec4376fda2fb5.1450031251.git.yann.morin.1998@free.fr> <56714B61.8040308@lucaceresoli.net> <5671E9E9.4090705@lucaceresoli.net> <20151216230503.GB3448@free.fr> Message-ID: <5671EF35.4080902@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 17-12-15 00:05, Yann E. MORIN wrote: > Luca, All, > > On 2015-12-16 23:47 +0100, Luca Ceresoli spake thusly: >> Luca Ceresoli wrote: >> [...] >>>> +# Download actual sources if they differ from the extracted sources >>>> +# (e.g. for external toolchains) >>>> +# >>>> +# We need to provide PKG and PKGDIR, because there's no .stamp file for >>>> +# the legal-info step. >>>> +$(1)-legal-source: PKG=$(2) >>>> +$(1)-legal-source: PKGDIR=$(pkgdir) >>>> +$(1)-legal-source: >>>> +ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),) >>>> +ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_SOURCE)) >>>> + $$(call >>>> DOWNLOAD,$$($(2)_ACTUAL_SOURCE_SITE)/$$($(2)_ACTUAL_SOURCE_TARBALL)) >>>> +endif # actuall sources != sources >>> >>> actuall sources -> actual source >>> >>>> +endif # actuall source != "" >>> >>> actuall -> actual >>> >>> With these fixed: >>> Acked-by: Luca Ceresoli >>> >>> [Tested with a minimal Sourcery ARM 2014.05 config] >>> Tested-by: Luca Ceresoli >> >> Hey, NO! This patch is wrong. > [--SNIP--] >> with this defconfig: >> >> BR2_arm=y >> BR2_TOOLCHAIN_EXTERNAL=y >> >> But it breaks online 'make legal-info' when _ACTUAL_SOURCES have not >> yet been downloaded, i.e.: >> >> $ make clean >> $ rm -fr dl/ >> $ make legal-info >> [...] >> cp: cannot stat '/home/murray/devel/buildroot/dl/arm-2014.05-29-arm-none-linux-gnueabi.src.tar.bz2': >> No such file or directory > > Damit... :-( > >> I think this is because you moved the downloading of _ACTUAL_SOURCE >> from the $(1)-legal-info to $(1)-legal-source, and the former does not >> depend on the latter. >> >> Perhaps we just need this? >> >> $(1)-legal-info: $(1)-legal-source > > Nope, that does not work either. The download indeed occurs, but then it > can not find a hash for it. Indeed, we do not have ssuch a hash > anywhere. Isn't it just that we need to add hashes for the _ACTUAL_SOURCE_TARBALLs that we have? Regards, Arnout > > I'll investigate tomorrow (or this WE). > >> Sorry for having missed this during my first review. > > No problem, thank you very much for the testing! :-) > > Regards, > Yann E. MORIN. > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF