Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] qemu: wrap lines to 72 characters length
Date: Thu, 17 Dec 2015 12:31:08 +0000	[thread overview]
Message-ID: <5672AB0C.7050806@imgtec.com> (raw)
In-Reply-To: <20151217130858.058c2c65@free-electrons.com>

On 17/12/15 12:08, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> I'm with the commit, with one exception.
> 
> On Thu, 17 Dec 2015 11:57:07 +0000, Vicente Olivert Riera wrote:
> 
>> diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
>> index c5c3f05..e9b944b 100644
>> --- a/package/qemu/Config.in.host
>> +++ b/package/qemu/Config.in.host
>> @@ -3,15 +3,16 @@ config BR2_PACKAGE_HOST_QEMU
>>  	# So far, we only build the user mode emulation, so this list
>>  	# of architecture dependencies only takes into account this
>>  	# emulation mode.
>> -	depends on BR2_arm       || BR2_armeb       || BR2_aarch64      || \
>> -		BR2_i386         || BR2_m68k        || BR2_microblazeel || \
>> -		BR2_microblazebe || BR2_mips        || BR2_mipsel       || \
>> -		BR2_mips64       || BR2_mips64el    || BR2_powerpc      || \
>> -		BR2_powerpc64    || BR2_powerpc64le || BR2_sh           || \
>> -		BR2_sparc        || BR2_x86_64
>> +	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || \
>> +		BR2_m68k || BR2_microblazeel || BR2_microblazebe || \
>> +		BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el \
>> +		|| BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
>> +		BR2_sh || BR2_sparc || BR2_x86_64
> 
> Why are you doing this? The original version is much more readable.

Ok, no problem. You can apply the patch with that part removed. Or do
you prefer a v2?

Regards,

Vincent.

> Thomas
> 

  reply	other threads:[~2015-12-17 12:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 11:57 [Buildroot] [PATCH 1/3] qemu: bump version to 2.5.0 Vicente Olivert Riera
2015-12-17 11:57 ` [Buildroot] [PATCH 2/3] qemu: wrap lines to 72 characters length Vicente Olivert Riera
2015-12-17 12:08   ` Thomas Petazzoni
2015-12-17 12:31     ` Vicente Olivert Riera [this message]
2015-12-17 11:57 ` [Buildroot] [PATCH 3/3] qemu: fix project's URL Vicente Olivert Riera
2015-12-17 12:09   ` Thomas Petazzoni
2015-12-17 12:29     ` Vicente Olivert Riera
2015-12-17 12:46       ` Thomas Petazzoni
2015-12-17 12:08 ` [Buildroot] [PATCH 1/3] qemu: bump version to 2.5.0 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5672AB0C.7050806@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox