From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] toolchain-external: CodeSourcery ARM: support only one version
Date: Sat, 19 Dec 2015 23:36:38 +0100 [thread overview]
Message-ID: <5675DBF6.2090308@mind.be> (raw)
In-Reply-To: <1450548886-21937-1-git-send-email-romain.naour@openwide.fr>
On 19-12-15 19:14, Romain Naour wrote:
> See the conclusion about external toolchains during the Buildroot
> meeting [1]:
> "In the future, we stick to a single external toolchain version. The
> Kconfig symbol should not encode the version (avoid legacy handling)"
>
> [1] http://elinux.org/index.php?title=Buildroot:DeveloperDaysELCE2015#Report
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> toolchain/toolchain-external/Config.in | 65 +---------------------
> .../toolchain-external/toolchain-external.hash | 2 -
> toolchain/toolchain-external/toolchain-external.mk | 8 +--
One remark here (which applies to the whole series): it lacks legacy handling.
I would propose to let all of the removed symbols select
BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM.
Otherwise, looks good to me.
Regards,
Arnout
> 3 files changed, 3 insertions(+), 72 deletions(-)
>
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index 656e012..a8f19aa 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -101,7 +101,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_ARMEB
> generated is Thumb 2, with the hard floating point calling
> convention, and uses the VFPv3-D16 FPU instructions.
>
> -config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201405
> +config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
> bool "Sourcery CodeBench ARM 2014.05"
> depends on BR2_arm
> depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2015-12-19 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 18:14 [Buildroot] [PATCH 1/7] toolchain-external: CodeSourcery ARM: support only one version Romain Naour
2015-12-19 18:14 ` [Buildroot] [PATCH 2/7] toolchain-external: CodeSourcery PowerPC: " Romain Naour
2015-12-26 9:46 ` Yann E. MORIN
2015-12-19 18:14 ` [Buildroot] [PATCH 3/7] toolchain-external: CodeSourcery SH: " Romain Naour
2015-12-19 18:14 ` [Buildroot] [PATCH 4/7] toolchain-external: CodeSourcery x86: " Romain Naour
2015-12-19 18:14 ` [Buildroot] [PATCH 5/7] toolchain-external: ADI Blackfin: " Romain Naour
2015-12-19 18:14 ` [Buildroot] [PATCH 6/7] toolchain-external: Synopsys ARC: " Romain Naour
2015-12-19 18:14 ` [Buildroot] [PATCH 7/7] toolchain-external: Ti Arago ARM: " Romain Naour
2015-12-19 22:36 ` Arnout Vandecappelle [this message]
2015-12-20 9:28 ` [Buildroot] [PATCH 1/7] toolchain-external: CodeSourcery " Thomas Petazzoni
2015-12-20 12:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5675DBF6.2090308@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox