Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ACS CCID PC/SC Driver added.
Date: Wed, 30 Dec 2015 22:48:42 +0100	[thread overview]
Message-ID: <5684513A.80005@mind.be> (raw)
In-Reply-To: <1451488583-1546-1-git-send-email-juha@codercoded.com>

 Hi Juha,

 Still a few more things that Thomas missed.

On 30-12-15 16:16, Juha Rantanen wrote:
> Fixes for acsccid.
> 
> Signed-off-by: Juha Rantanen <juha@codercoded.com>
> ---
> Changes v1 -> v2:
>   - syntax fixes
>   - removed flex and perl deps
>   - libusb optional
>   - added license
> 
>  package/Config.in          |  1 +
>  package/acsccid/Config.in  | 12 ++++++++++++
>  package/acsccid/acsccid.mk | 22 ++++++++++++++++++++++

 You should also add a hash file, see
http://nightly.buildroot.org/#adding-packages-hash

>  3 files changed, 35 insertions(+)
>  create mode 100644 package/acsccid/Config.in
>  create mode 100644 package/acsccid/acsccid.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index ef03632..25e574f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -907,6 +907,7 @@ menu "Graphics"
>  endmenu
>  
>  menu "Hardware handling"
> +	source "package/acsccid/Config.in"
>  	source "package/bcm2835/Config.in"
>  	source "package/c-periphery/Config.in"
>  	source "package/ccid/Config.in"
> diff --git a/package/acsccid/Config.in b/package/acsccid/Config.in
> new file mode 100644
> index 0000000..b5af1d0
> --- /dev/null
> +++ b/package/acsccid/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_ACSCCID
> +	bool "acsccid"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_PCSC_LITE
> +	help
> +	  acsccid is a PC/SC driver for Linux/Mac OS X and it supports ACS CCID

 Still a bit too long, the tab counts as 8 characters so there should be just 62
"real" characters on the line.

> +	  smart card readers.
> +
> +	  http://acsccid.sourceforge.net/
> +
> +comment "acsccid needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/acsccid/acsccid.mk b/package/acsccid/acsccid.mk
> new file mode 100644
> index 0000000..3d24414
> --- /dev/null
> +++ b/package/acsccid/acsccid.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# acsccid
> +#
> +################################################################################
> +
> +ACSCCID_VERSION = 1.1.1
> +ACSCCID_SOURCE = acsccid-$(ACSCCID_VERSION).tar.bz2
> +ACSCCID_SITE = http://downloads.sourceforge.net/acsccid
> +ACSCCID_LICENSE = LGPLv2.1+
> +ACSCCID_LICENSE_FILES = COPYING
> +ACSCCID_INSTALL_STAGING = YES
> +ACSCCID_DEPENDENCIES = pcsc-lite host-perl host-flex host-pkgconf

 I would be surprised if host-perl is really needed, normally the system perl
should be sufficient.

 Regards,
 Arnout

> +
> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
> +ACSCCID_DEPENDENCIES += libusb
> +ACSCCID_CONF_OPTS += --enable-libusb
> +else
> +ACSCCID_CONF_OPTS += --disable-libusb
> +endif
> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-12-30 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 11:33 [Buildroot] [PATCH 0/1] ACS CCID PC/SC Driver Juha Rantanen
2015-12-30 11:33 ` [Buildroot] [PATCH 1/1] ACS CCID PC/SC Driver added Juha Rantanen
2015-12-30 13:19   ` Thomas Petazzoni
2015-12-30 15:16   ` [Buildroot] [PATCH v2] " Juha Rantanen
2015-12-30 21:48     ` Arnout Vandecappelle [this message]
2015-12-30 22:20     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5684513A.80005@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox