From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Thu, 31 Dec 2015 00:45:19 +0100 Subject: [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in In-Reply-To: <805bddfa16ccc143f1c0a871d7304af0f2b155c7.1451076704.git.yann.morin.1998@free.fr> References: <805bddfa16ccc143f1c0a871d7304af0f2b155c7.1451076704.git.yann.morin.1998@free.fr> Message-ID: <56846C8F.50308@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 25-12-15 22:24, Yann E. MORIN wrote: > ... and make it a menuconfig instead of a 'config'+'menu'. I don't agree with this change, because these are really separate packages, not suboptions of the jquery package. Similar for python, where it is even more obvious because as indicated by the symlink hack for python3. Regards, Arnout > > Signed-off-by: "Yann E. MORIN" > --- > package/Config.in | 12 ------------ > package/jquery/Config.in | 17 ++++++++++++++++- > 2 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/package/Config.in b/package/Config.in > index dd44743..73a3ac8 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -951,18 +951,6 @@ menu "Javascript" > source "package/explorercanvas/Config.in" > source "package/flot/Config.in" > source "package/jquery/Config.in" > -if BR2_PACKAGE_JQUERY > -menu "External jQuery plugins" > - source "package/jquery-datetimepicker/Config.in" > - source "package/jquery-keyboard/Config.in" > - source "package/jquery-mobile/Config.in" > - source "package/jquery-sidebar/Config.in" > - source "package/jquery-sparkline/Config.in" > - source "package/jquery-ui/Config.in" > - source "package/jquery-ui-themes/Config.in" > - source "package/jquery-validation/Config.in" > -endmenu > -endif > source "package/jsmin/Config.in" > source "package/json-javascript/Config.in" > endmenu > diff --git a/package/jquery/Config.in b/package/jquery/Config.in > index 92f5604..3133702 100644 > --- a/package/jquery/Config.in > +++ b/package/jquery/Config.in > @@ -1,4 +1,4 @@ > -config BR2_PACKAGE_JQUERY > +menuconfig BR2_PACKAGE_JQUERY > bool "jQuery" > help > jQuery is a fast and concise JavaScript Library that > @@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY > animating, and Ajax interactions for rapid web development. > > http://jquery.com > + > +if BR2_PACKAGE_JQUERY > + > +comment "External jQuery plugins" > + > +source "package/jquery-datetimepicker/Config.in" > +source "package/jquery-keyboard/Config.in" > +source "package/jquery-mobile/Config.in" > +source "package/jquery-sidebar/Config.in" > +source "package/jquery-sparkline/Config.in" > +source "package/jquery-ui/Config.in" > +source "package/jquery-ui-themes/Config.in" > +source "package/jquery-validation/Config.in" > + > +endif > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF