From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [alternative PATCH] fakeroot: fix build when libcap-dev is installed
Date: Mon, 4 Jan 2016 22:30:20 +0100 [thread overview]
Message-ID: <568AE46C.9040104@mind.be> (raw)
In-Reply-To: <1451932436-27742-1-git-send-email-ricardo.martincoski@gmail.com>
On 04-01-16 19:33, Ricardo Martincoski wrote:
> Fixes https://bugs.busybox.net/show_bug.cgi?id=8541
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(various cases with and without host- and system-libcap)
In addition, this patch fixes the issue that the build of host-fakeroot will be
different depending on whether host-libcap was built before or not.
Regards,
Arnout
> ---
> Alternative patch to https://patchwork.ozlabs.org/patch/562348/
>
> We don't need libcap for buildroot, as Gustavo Zacarias explained in the past.
> It seems reasonable to me to disable this detection too.
>
> I can reproduce the original bug with libcap-dev in my Ubuntu 14.04.
> Using this patch I cannot reproduce the bug anymore.
> ---
> package/fakeroot/fakeroot.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/fakeroot/fakeroot.mk b/package/fakeroot/fakeroot.mk
> index 837c2b9..168cd13 100644
> --- a/package/fakeroot/fakeroot.mk
> +++ b/package/fakeroot/fakeroot.mk
> @@ -10,7 +10,10 @@ FAKEROOT_SITE = http://snapshot.debian.org/archive/debian/20141005T221953Z/pool/
> # Force capabilities detection off
> # For now these are process capabilities (faked) rather than file
> # so they're of no real use
> -HOST_FAKEROOT_CONF_ENV = ac_cv_func_capset=no
> +HOST_FAKEROOT_CONF_ENV = \
> + ac_cv_header_sys_capability_h=no \
> + ac_cv_func_capset=no
> +
> FAKEROOT_LICENSE = GPLv3+
> FAKEROOT_LICENSE_FILES = COPYING
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-01-04 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:33 [Buildroot] [alternative PATCH] fakeroot: fix build when libcap-dev is installed Ricardo Martincoski
2016-01-04 21:30 ` Arnout Vandecappelle [this message]
2016-01-04 21:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568AE46C.9040104@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox