Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH 1/3] package/dhcp: bump version to 4.3.3
Date: Sun, 10 Jan 2016 17:01:55 +0100	[thread overview]
Message-ID: <56928073.9010001@mind.be> (raw)
In-Reply-To: <1452376785-31174-2-git-send-email-rdkehn@yahoo.com>

On 09-01-16 22:59, Doug Kehn wrote:
[snip]
> +define DHCP_TOOLCHAIN_AR_REF
> +	for d in common dhcpctl omapip; do \
> +		sed -i 's#^AR.*#AR = $(TARGET_AR)#' $(@D)/$$d/Makefile; \
> +	done
> +endef
> +DHCP_PRE_BUILD_HOOKS += DHCP_TOOLCHAIN_AR_REF

 This should be a post-patch hook. Or if the Makefile is generated by the
configure step, a post-configure hook (but in that case it would be better to
patch the configure script to generate the right thing to begin with).

 Oh yes, even better is an actual patch that can be upstreamed.

 Regards,
 Arnout

> +
>  ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
>  DHCP_CONF_OPTS += --enable-delayed-ack
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-01-10 16:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 21:59 [Buildroot] [RFC PATCH 0/3] package/dhcp Doug Kehn
2016-01-09 21:59 ` [Buildroot] [RFC PATCH 1/3] package/dhcp: bump version to 4.3.3 Doug Kehn
2016-01-10 16:01   ` Arnout Vandecappelle [this message]
2016-01-10 16:52     ` rdkehn at yahoo.com
2016-01-09 21:59 ` [Buildroot] [RFC PATCH 2/3] package/dhcp: fix bind configure for cross-compiling Doug Kehn
2016-01-09 21:59 ` [Buildroot] [RFC PATCH 3/3] package/dhcp: ensure host cc is used for compiling gen Doug Kehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56928073.9010001@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox