From: Eial Czerwacki <eial@scalemp.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] pixman: add patch to fix build issue with musl
Date: Sun, 17 Jan 2016 17:38:11 +0200 [thread overview]
Message-ID: <569BB563.8020706@scalemp.com> (raw)
In-Reply-To: <569BA820.6040300@scalemp.com>
the patch above fixed the issue, thanks.
now I have a python related failure but I'll send another mail on it.
On 01/17/2016 04:41 PM, Eial Czerwacki wrote:
> thanks, will try.
>
> On 01/17/2016 04:40 PM, Thomas Petazzoni wrote:
>> pixman fails to build with musl because <float.h> is included in
>> assembler files, which doesn't work with the <float.h> provided by
>> musl. This commit fixes that by patching pixman (patch submitted
>> upstream).
>>
>> Reported-by: Eial Czerwacki <eial@scalemp.com>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> ---
>> ...an-private-include-float.h-only-in-C-code.patch | 46 ++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>> create mode 100644 package/pixman/0002-pixman-private-include-float.h-only-in-C-code.patch
>>
>> diff --git a/package/pixman/0002-pixman-private-include-float.h-only-in-C-code.patch b/package/pixman/0002-pixman-private-include-float.h-only-in-C-code.patch
>> new file mode 100644
>> index 0000000..455cebb
>> --- /dev/null
>> +++ b/package/pixman/0002-pixman-private-include-float.h-only-in-C-code.patch
>> @@ -0,0 +1,46 @@
>> +From 2a5b33fe5cb921993573392afac19185e224b49a Mon Sep 17 00:00:00 2001
>> +From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> +Date: Sun, 17 Jan 2016 14:14:28 +0100
>> +Subject: [PATCH] pixman-private: include <float.h> only in C code
>> +
>> +<float.h> is included unconditionally by pixman-private.h, which in
>> +turn gets included by assembler files. Unfortunately, with certain C
>> +libraries (like the musl C library), <float.h> cannot be included in
>> +assembler files:
>> +
>> + CCLD libpixman-arm-simd.la
>> +/home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h: Assembler messages:
>> +/home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:8: Error: bad instruction `int __flt_rounds(void)'
>> +/home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h: Assembler messages:
>> +/home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:8: Error: bad instruction `int __flt_rounds(void)'
>> +
>> +It turns out however that <float.h> is not needed by assembly files,
>> +so we move its inclusion within the #ifndef __ASSEMBLER__ condition,
>> +which solves the problem.
>> +
>> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> +---
>> + pixman/pixman-private.h | 3 +--
>> + 1 file changed, 1 insertion(+), 2 deletions(-)
>> +
>> +diff --git a/pixman/pixman-private.h b/pixman/pixman-private.h
>> +index 73108a0..73a5414 100644
>> +--- a/pixman/pixman-private.h
>> ++++ b/pixman/pixman-private.h
>> +@@ -1,5 +1,3 @@
>> +-#include <float.h>
>> +-
>> + #ifndef PIXMAN_PRIVATE_H
>> + #define PIXMAN_PRIVATE_H
>> +
>> +@@ -30,6 +28,7 @@
>> + #include <stdio.h>
>> + #include <string.h>
>> + #include <stddef.h>
>> ++#include <float.h>
>> +
>> + #include "pixman-compiler.h"
>> +
>> +--
>> +2.6.4
>> +
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
next prev parent reply other threads:[~2016-01-17 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 14:39 [Buildroot] [PATCH 1/2] pixman: bump version to 0.33.6 Thomas Petazzoni
2016-01-17 14:40 ` [Buildroot] [PATCH 2/2] pixman: add patch to fix build issue with musl Thomas Petazzoni
2016-01-17 14:41 ` Eial Czerwacki
2016-01-17 15:38 ` Eial Czerwacki [this message]
2016-01-20 6:25 ` Eial Czerwacki
2016-01-20 9:13 ` Thomas Petazzoni
2016-01-27 22:49 ` [Buildroot] [PATCH 1/2] pixman: bump version to 0.33.6 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569BB563.8020706@scalemp.com \
--to=eial@scalemp.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox