Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 2/2] remove download suppression from mke2img and skeleton
Date: Mon, 25 Jan 2016 01:16:16 +0100	[thread overview]
Message-ID: <56A56950.4060105@mind.be> (raw)
In-Reply-To: <CAAXf6LVDeQLa+NFb5P_HPdh_wbEvv60F59v=suCSsGbcCM=WKg@mail.gmail.com>

On 20-01-16 15:14, Thomas De Schampheleire wrote:
> On Tue, Jan 19, 2016 at 11:33 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> Alex, All,
>>
>> On 2015-10-01 00:13 +0300, Alex Suykov spake thusly:
>>> With non-versioned packages patch applied, there is no need
>>> to set empty _SOURCE.
>>>
>>> Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
>>
>> After the previous patch has been applied:
>>
>> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[snip]
>>> -# source included in buildroot
>>> -SKELETON_SOURCE =
>>> -
>>>  # The skeleton can't depend on the toolchain, since all packages depends on the
>>>  # skeleton and the toolchain is a target package, as is skeleton.
>>>  # Hence, skeleton would depends on the toolchain and the toolchain would depend
>>
> 
> Question is whether it is correct that mke2img and skeleton are unversioned.
> Packages that are similar are makedevs, mkpasswd and getent, where the
> _VERSION is explicitly set to match the Buildroot version:
> MAKEDEVS_VERSION = buildroot-$(BR2_VERSION)
> I think that mke2img is in the same boat as these packages, and so
> should follow the same strategy.

 +1 to that.

 Alex, will you send a v2 that sets the version of mke2img and skeleton to
buildroot-$(BR2_VERSION) instead?


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-01-25  0:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 21:12 [Buildroot] [RFC 1/2] non-versioned packages Alex Suykov
2015-09-30 21:13 ` [Buildroot] [RFC 2/2] remove download suppression from mke2img and skeleton Alex Suykov
2016-01-19 22:33   ` Yann E. MORIN
2016-01-20 14:14     ` Thomas De Schampheleire
2016-01-25  0:16       ` Arnout Vandecappelle [this message]
2015-09-30 22:15 ` [Buildroot] [RFC 1/2] non-versioned packages Yann E. MORIN
2015-09-30 22:52   ` Alex Suykov
2015-10-15 20:41 ` Thomas Petazzoni
2015-10-15 22:31   ` Arnout Vandecappelle
2016-01-19 22:32 ` Yann E. MORIN
2016-01-24 22:33   ` Alex Suykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A56950.4060105@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox