From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libcurl: enable mbedtls support
Date: Mon, 1 Feb 2016 17:27:52 +0100 [thread overview]
Message-ID: <56AF8788.7090702@lucaceresoli.net> (raw)
In-Reply-To: <1452106417-12097-1-git-send-email-gustavo@zacarias.com.ar>
Hi Gustavo,
Gustavo Zacarias wrote:
> Now that we've got an mbedtls package in the tree we can enable the
> optional support for it in libcurl.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/libcurl/libcurl.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
> index 10514c6..8798d71 100644
> --- a/package/libcurl/libcurl.mk
> +++ b/package/libcurl/libcurl.mk
> @@ -40,10 +40,12 @@ else ifeq ($(BR2_PACKAGE_LIBNSS),y)
> LIBCURL_CONF_OPTS += --with-nss=$(STAGING_DIR)/usr
> LIBCURL_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) `$(PKG_CONFIG_HOST_BINARY) nspr nss --cflags`"
> LIBCURL_DEPENDENCIES += libnss
> +else ifeq ($(BR2_PACKAGE_MBEDTLS),y)
> +LIBCURL_CONF_OPTS += --with-mbedtls=$(STAGING_DIR)/usr
> +LIBCURL_DEPENDENCIES += mbedtls
> else
> -# polarssl support needs 1.3.x
This is unrelated to your change, it should be a separate patch. But
anyway I don't understand why it should be removed: we still package
polarssl 1.2.18, so the comment should still apply. Am I missing
something?
With that fixed (or explained):
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
And:
[Built with/without mbedtls, ran on qemu, checked that 'curl -V' shows
the SSL only with mbedtls]
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
next prev parent reply other threads:[~2016-02-01 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 18:53 [Buildroot] [PATCH] libcurl: enable mbedtls support Gustavo Zacarias
2016-02-01 16:27 ` Luca Ceresoli [this message]
2016-02-01 16:34 ` Gustavo Zacarias
2016-02-01 17:52 ` Luca Ceresoli
2016-02-01 17:56 ` Gustavo Zacarias
2016-02-01 18:02 ` Luca Ceresoli
2016-02-01 18:03 ` Gustavo Zacarias
2016-02-01 18:07 ` Luca Ceresoli
2016-02-01 18:08 ` Gustavo Zacarias
2016-03-08 20:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF8788.7090702@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox