From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 1 Feb 2016 21:01:40 +0100 Subject: [Buildroot] [PATCH v6 06/13] core: make host *-config scripts relocatable In-Reply-To: <20160201194554.743ace10@free-electrons.com> References: <1454342021-22960-1-git-send-email-s.martin49@gmail.com> <1454342021-22960-7-git-send-email-s.martin49@gmail.com> <20160201194554.743ace10@free-electrons.com> Message-ID: <56AFB9A4.7050401@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 01-02-16 19:45, Thomas Petazzoni wrote: > Dear Samuel Martin, > > On Mon, 1 Feb 2016 16:53:34 +0100, Samuel Martin wrote: > >> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk >> index 1bf613e..ca79450 100644 >> --- a/package/pkg-generic.mk >> +++ b/package/pkg-generic.mk >> @@ -207,6 +207,18 @@ $(BUILD_DIR)/%/.stamp_host_installed: >> $(foreach hook,$($(PKG)_PRE_INSTALL_HOOKS),$(call $(hook))$(sep)) >> +$($(PKG)_INSTALL_CMDS) >> $(foreach hook,$($(PKG)_POST_INSTALL_HOOKS),$(call $(hook))$(sep)) >> + $(Q)if test -n "$($(RAWNAME)_CONFIG_SCRIPTS)" ; then \ > > So you're testing if the current package has defined some > _CONFIG_SCRIPTS variable.... > >> + $(call MESSAGE,"Fixing package configuration files") ;\ >> + ls $(HOST_DIR)/usr/bin/*-config 2>/dev/null |\ > > But do the replacement on all *-config scripts ? > > This doesn't look good, and I think we should be changing just the ones > that are in _CONFIG_SCRIPTS. > > I read your commit log saying that this is a bit complicated due to > some packages installing config scripts whose name depend on the host > system. Can you give some specific examples to see if we can address > this ? Indeed, I would prefer an explicit HOST_PKG_CONFIG_SCRIPTS variable. You can easily look for the ones which are needed with git grep -l _CONFIG_SCRIPTS | xargs grep -l 'host-.*-package' And since this fixup is completely new, it can be a separate patch per package. Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF