From: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: aespipe: add host variant
Date: Tue, 2 Feb 2016 18:36:33 -0300 [thread overview]
Message-ID: <56B12161.3090501@vanguardiasur.com.ar> (raw)
In-Reply-To: <56AFA6D4.3060109@mind.be>
Arnout,
El 01/02/16 a las 15:41, Arnout Vandecappelle escribi?:
> On 01-02-16 16:37, Ariel D'Alessandro wrote:
>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>
> Your commit message should explain why this is needed. Something like:
>
> Post-image scripts may want to encrypt the resulting image with aespipe
> (and decrypt it in the update tool on the target), so it is useful to have
> the host version and to be able to select it in the configuration.
Yeah, I think that explanation is pretty good. I'll add it.
>
>> ---
>> package/Config.in.host | 1 +
>> package/aespipe/Config.in.host | 10 ++++++++++
>> package/aespipe/aespipe.mk | 1 +
>> 3 files changed, 12 insertions(+)
>> create mode 100644 package/aespipe/Config.in.host
>>
>> diff --git a/package/Config.in.host b/package/Config.in.host
>> index 8e6b870..1c691a3 100644
>> --- a/package/Config.in.host
>> +++ b/package/Config.in.host
>> @@ -1,5 +1,6 @@
>> menu "Host utilities"
>>
>> + source "package/aespipe/Config.in.host"
>> source "package/checkpolicy/Config.in.host"
>> source "package/cramfs/Config.in.host"
>> source "package/dfu-util/Config.in.host"
>> diff --git a/package/aespipe/Config.in.host b/package/aespipe/Config.in.host
>> new file mode 100644
>> index 0000000..29f6232
>> --- /dev/null
>> +++ b/package/aespipe/Config.in.host
>> @@ -0,0 +1,10 @@
>> +config BR2_PACKAGE_HOST_AESPIPE
>> + bool "host aespipe"
>> + depends on BR2_USE_MMU # fork()
>
> This shouldn't be there. If the target doesn't have a MMU, you can still build
> it for the host.
>
> Otherwise looks good to me.
Oops, you're right, don't know why I missed that :(
Thanks!
--
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2016-02-02 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:37 [Buildroot] [PATCH] package: aespipe: add host variant Ariel D'Alessandro
2016-02-01 18:41 ` Arnout Vandecappelle
2016-02-02 21:36 ` Ariel D'Alessandro [this message]
2016-02-01 19:02 ` Thomas Petazzoni
2016-02-02 21:43 ` Ariel D'Alessandro
2016-02-03 8:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B12161.3090501@vanguardiasur.com.ar \
--to=ariel@vanguardiasur.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox