Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] yad: fix libgtk2 related dependency error
Date: Wed, 3 Feb 2016 09:17:48 -0300	[thread overview]
Message-ID: <56B1EFEC.4040801@zacarias.com.ar> (raw)
In-Reply-To: <1454464356-12637-1-git-send-email-ricardo.martincoski@gmail.com>

On 02/02/16 22:52, Ricardo Martincoski wrote:

> --- a/package/yad/Config.in
> +++ b/package/yad/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_YAD
>   	bool "yad"
>   	depends on BR2_PACKAGE_XORG7
>   	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> +	select BR2_PACKAGE_LIBGTK3_X11 if BR2_PACKAGE_LIBGTK3
>   	help
>   	  YAD (yet another dialog) is a tool for create graphical dialogs
>   	  from shell scripts.

Hi.
This logic is severely broken, you can't force X11 if someone is using 
gtk3 with say broadway or wayland.
Not to mention BR2_PACKAGE_LIBGTK3_X11 depends on xorg being selected.

> -ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
> +ifeq ($(BR2_PACKAGE_LIBGTK3),y)

This isn't accurate either, you first say it needs x11 by selecting it, 
but you then basically say no?
Regards.

  parent reply	other threads:[~2016-02-03 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03  1:52 [Buildroot] [PATCH 1/2] yad: fix libgtk2 related dependency error Ricardo Martincoski
2016-02-03  1:52 ` [Buildroot] [PATCH 2/2] yad: bump to version 0.33.1 Ricardo Martincoski
2016-02-07 22:33   ` Thomas Petazzoni
2016-02-03 12:17 ` Gustavo Zacarias [this message]
2016-02-05 19:58   ` [Buildroot] [PATCH 1/2] yad: fix libgtk2 related dependency error Arnout Vandecappelle
     [not found] <mailman.2229.1454536893.28235.buildroot@busybox.net>
2016-02-03 23:15 ` Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B1EFEC.4040801@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox