From: Joao Pinto <Joao.Pinto@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v9] board: add support for ARM Juno r0 and r1 Development Boards
Date: Thu, 4 Feb 2016 11:15:27 +0000 [thread overview]
Message-ID: <56B332CF.5060207@synopsys.com> (raw)
In-Reply-To: <20160204000717.1be2fd28@free-electrons.com>
Hi Thomas,
I will check it and send a v10 today. Thanks for the buildroot' defconfig tip.
Joao
On 2/3/2016 11:07 PM, Thomas Petazzoni wrote:
> Joao,
>
> On Wed, 3 Feb 2016 18:20:30 +0000, Joao Pinto wrote:
>> The Juno ARM Development Platform (ADP) is a software development
>> platform for ARMv8-A, it includes the Juno Versatile Express board
>> and an ARMv8-A reference software port available through Linaro.
>>
>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>
> I am not sure why your v9 does not appear in patchwork, but v8 does.
> Anyway, this is still not good, because the kernel commit your
> defconfig uses no longer exists in the Linaro Git repository, so the
> download fails:
>
>>>> linux 0d752ce2de3057e12e220d104beb02744147be4f Downloading
> Doing full clone
> Cloning into bare repository 'linux-0d752ce2de3057e12e220d104beb02744147be4f'...
> fatal: not a tree object
>
> It works for you because you have the tarball'ed kernel in your
> $(BR2_DL_DIR), but it won't work for anyone else.
>
> You should make sure to use a commit in a branch that the Linaro
> developers will not rebase, otherwise the commit will disappear in the
> future.
>
> Also, another problem of your submission is that you're adding two
> defconfigs, while there's no reason to do so. The only difference
> between the two is the Device Tree to be built. And we can perfectly
> build two Device Trees in a single defconfig.
>
> So could you apply the attached patch on top of yours (which addresses
> this problem), and squash it with your commit ?
>
> Thanks!
>
> Thomas
>
prev parent reply other threads:[~2016-02-04 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 18:18 [Buildroot] [PATCH v8] board: add support for ARM Juno r0 and r1 Development Boards Joao Pinto
2016-02-03 23:07 ` [Buildroot] [PATCH v9] " Thomas Petazzoni
2016-02-04 11:15 ` Joao Pinto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B332CF.5060207@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox