Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] linux: add conditional patch for timeconst.pl
Date: Tue, 9 Feb 2016 20:19:14 -0300	[thread overview]
Message-ID: <56BA73F2.7080009@free-electrons.com> (raw)
In-Reply-To: <56BA718A.5060500@mind.be>

On 09/02/16 20:08, Arnout Vandecappelle wrote:

>   and debian testing (stretch) and unstable (sid).
>
>   As Thomas said, it's dirty, but we really need this.

Hi Arnout.
Yes, i couldn't figure out a cleaner way to do this, continues below...

>   The only reason to use APPLY_PATCHES is that it updates .applied_patches_list,
> right? In that case, perhaps it's better to do that directly here. So instead of
> a dry-run, just apply the patch right away, and if it succeeds add it to
> .applied_patches_list.

I could have probed the timeconst.pl file presence and relevancy (if it 
contains defined(@array)...), but then a dry-run patch does that for me 
just fine with the proper parameters.
Yes, that's the reason for APPLY_PATCHES, however since it's already 
there why bother duplicating code?
Also thought of extending apply-patches.sh to add an option for 
try-do/discard, but i believe it's a double-edged sword and not worth it 
quite yet.

>   This is a patch that we probably _do_ want to apply even in case of
> OVERRIDE_SRCDIR. So maybe add it to LINUX_PRE_CONFIGURE_HOOKS instead. Even
> though that's even more of a hack (and conflicts with the out-of-tree build
> support).

Possibly, let's hear other people thoughts on this.
Regards.

  reply	other threads:[~2016-02-09 23:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 13:41 [Buildroot] [PATCH v2] linux: add conditional patch for timeconst.pl gustavo.zacarias at free-electrons.com
2016-02-07 14:50 ` Thomas Petazzoni
2016-02-09 23:08 ` Arnout Vandecappelle
2016-02-09 23:19   ` Gustavo Zacarias [this message]
2016-02-10  0:37     ` Arnout Vandecappelle
2016-02-10  1:27       ` Gustavo Zacarias
2016-02-10  7:11   ` Peter Korsgaard
2016-02-10  7:12 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA73F2.7080009@free-electrons.com \
    --to=gustavo.zacarias@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox